Congegni
/
libretime
mirror of https://github.com/libretime/libretime.git
7
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

feat!: default system output is now `pulseaudio` (#2842) 

BREAKING CHANGE: The default system output
(`stream.outputs.system[].kind`) changed from `alsa` to `pulseaudio`.
Make sure to update your configuration file if you rely on the default
system output.

Closes #2542
This commit is contained in:
Jonas L 2023-12-27 18:23:40 +01:00 committed by GitHub
parent 0d2d1a2673
commit 083ee3f1dd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
8 changed files with 16 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
docker/config.template.yml
View File

@ -324,5 +324,5 @@ stream:
enabled: false enabled: false
# System output kind. # System output kind.
# > must be one of (alsa, ao, oss, portaudio, pulseaudio) # > must be one of (alsa, ao, oss, portaudio, pulseaudio)
# > default is alsa # > default is pulseaudio
kind: alsa kind: pulseaudio

4
docker/config.yml
View File

@ -324,5 +324,5 @@ stream:
enabled: false enabled: false
# System output kind. # System output kind.
# > must be one of (alsa, ao, oss, portaudio, pulseaudio) # > must be one of (alsa, ao, oss, portaudio, pulseaudio)
# > default is alsa # > default is pulseaudio
kind: alsa kind: pulseaudio

4
docker/example/config.yml
View File

@ -324,5 +324,5 @@ stream:
enabled: false enabled: false
# System output kind. # System output kind.
# > must be one of (alsa, ao, oss, portaudio, pulseaudio) # > must be one of (alsa, ao, oss, portaudio, pulseaudio)
# > default is alsa # > default is pulseaudio
kind: alsa kind: pulseaudio

4
docs/admin-manual/configuration.md
View File

@ -529,8 +529,8 @@ stream:
enabled: false enabled: false
# System output kind. # System output kind.
# > must be one of (alsa, ao, oss, portaudio, pulseaudio) # > must be one of (alsa, ao, oss, portaudio, pulseaudio)
# > default is alsa # > default is pulseaudio
kind: "alsa" kind: "pulseaudio"
``` ```
## LDAP ## LDAP

4
docs/releases/unreleased.md
View File

@ -30,6 +30,10 @@ Please follow this **before the upgrade procedure**.
The `general.secret_key` field in the [configuration file](../admin-manual/configuration.md#general) is now **required**, to prevent reusing the `general.api_key` for cryptographic usage. The `general.secret_key` field in the [configuration file](../admin-manual/configuration.md#general) is now **required**, to prevent reusing the `general.api_key` for cryptographic usage.
### The `stream.outputs.system[].kind` configuration field now defaults to `pulseaudio`
The `stream.outputs.system[].kind` field in the [configuration file](../admin-manual/configuration.md#general) default value changed from `alsa` to `pulseaudio`. Make sure to update your configuration file if you rely on the default system output.
## :warning: Known issues ## :warning: Known issues
The following issues may need a workaround for the time being. Please search the [issues](https://github.com/libretime/libretime/issues) before reporting problems not listed below. The following issues may need a workaround for the time being. Please search the [issues](https://github.com/libretime/libretime/issues) before reporting problems not listed below.

4
installer/config.yml
View File

@ -324,5 +324,5 @@ stream:
enabled: false enabled: false
# System output kind. # System output kind.
# > must be one of (alsa, ao, oss, portaudio, pulseaudio) # > must be one of (alsa, ao, oss, portaudio, pulseaudio)
# > default is alsa # > default is pulseaudio
kind: alsa kind: pulseaudio

2
legacy/application/configs/conf.php
View File

@ -207,7 +207,7 @@ class Schema implements ConfigurationInterface
// System outputs // System outputs
/**/->arrayNode('system')->arrayPrototype()->children() /**/->arrayNode('system')->arrayPrototype()->children()
/* */->booleanNode('enabled')->defaultFalse()->end() /* */->booleanNode('enabled')->defaultFalse()->end()
/* */->scalarNode('kind')->defaultValue('alsa') /* */->scalarNode('kind')->defaultValue('pulseaudio')
/* */->validate()->ifNotInArray(["alsa", "ao", "oss", "portaudio", "pulseaudio"]) /* */->validate()->ifNotInArray(["alsa", "ao", "oss", "portaudio", "pulseaudio"])
/* */->thenInvalid('invalid stream.outputs.system.kind %s') /* */->thenInvalid('invalid stream.outputs.system.kind %s')
/* */->end()->end() /* */->end()->end()

2
shared/libretime_shared/config/_models.py
View File

@ -226,7 +226,7 @@ class SystemOutputKind(str, Enum):
class SystemOutput(BaseModel): class SystemOutput(BaseModel):
enabled: bool = False enabled: bool = False
kind: SystemOutputKind = SystemOutputKind.ALSA kind: SystemOutputKind = SystemOutputKind.PULSEAUDIO
# pylint: disable=too-few-public-methods # pylint: disable=too-few-public-methods