SAAS-214: "--email" being inserted for "city" field in statistics

-fixed quote insertion if string is empty
This commit is contained in:
denise 2012-05-03 13:55:55 -04:00
parent 81d7e0c80f
commit 13e147540d
1 changed files with 11 additions and 6 deletions

View File

@ -27,20 +27,26 @@ class Application_Model_Preference
if($isUserValue) {
$sql .= " AND subjid = '$id'";
}
$result = $con->query($sql)->fetchColumn(0);
if($value == "") {
$value = "NULL";
}else {
$value = "'$value'";
}
if($result == 1) {
// result found
if(is_null($id) || !$isUserValue) {
// system pref
$sql = "UPDATE cc_pref"
." SET subjid = NULL, valstr = '$value'"
." SET subjid = NULL, valstr = $value"
." WHERE keystr = '$key'";
} else {
// user pref
$sql = "UPDATE cc_pref"
. " SET valstr = '$value'"
. " SET valstr = $value"
. " WHERE keystr = '$key' AND subjid = $id";
}
} else {
@ -48,14 +54,13 @@ class Application_Model_Preference
if(is_null($id) || !$isUserValue) {
// system pref
$sql = "INSERT INTO cc_pref (keystr, valstr)"
." VALUES ('$key', '$value')";
." VALUES ('$key', $value)";
} else {
// user pref
$sql = "INSERT INTO cc_pref (subjid, keystr, valstr)"
." VALUES ($id, '$key', '$value')";
." VALUES ($id, '$key', $value)";
}
}
return $con->exec($sql);
}