From 2f77c40ed4631534664e17f3e8e3caa0bb95eb51 Mon Sep 17 00:00:00 2001 From: Ciaby Date: Sat, 12 Jan 2019 00:34:06 +0100 Subject: [PATCH 1/3] Fix PodcastService PHP error in podcast generation --- airtime_mvc/application/services/PodcastService.php | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/airtime_mvc/application/services/PodcastService.php b/airtime_mvc/application/services/PodcastService.php index 8ea319772..0855e5743 100644 --- a/airtime_mvc/application/services/PodcastService.php +++ b/airtime_mvc/application/services/PodcastService.php @@ -412,8 +412,7 @@ class Application_Service_PodcastService if (empty($value)) { return null; } - $child = $node->addChild($name, null, $namespace); - $child->{0} = $value; + $child = $node->addChild($name, $value, $namespace); return $child; } From 5c250fc28acd0ab181b74623df2aa95fff53e716 Mon Sep 17 00:00:00 2001 From: Robbt Date: Wed, 24 Apr 2019 22:19:45 -0400 Subject: [PATCH 2/3] added additional escapes to fix podcast service --- airtime_mvc/application/services/PodcastService.php | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/airtime_mvc/application/services/PodcastService.php b/airtime_mvc/application/services/PodcastService.php index 0855e5743..d9362ebde 100644 --- a/airtime_mvc/application/services/PodcastService.php +++ b/airtime_mvc/application/services/PodcastService.php @@ -412,7 +412,9 @@ class Application_Service_PodcastService if (empty($value)) { return null; } - $child = $node->addChild($name, $value, $namespace); + $child = $node->addChild($name, null, $namespace); + Logging::info($value); + $child[0] = $value; return $child; } @@ -444,7 +446,7 @@ class Application_Service_PodcastService $imageUrl = Application_Common_HTTPHelper::getStationUrl()."api/station-logo"; $image = $channel->addChild("image"); - $image->addChild("title", $podcast->getDbTitle()); + $image->addChild("title", htmlspecialchars($podcast->getDbTitle())); self::addEscapedChild($image, "url", $imageUrl); self::addEscapedChild($image, "link", Application_Common_HTTPHelper::getStationUrl()); From bdb33bdd8372eca33fa16cece2f8fd4fbce9eec8 Mon Sep 17 00:00:00 2001 From: Robbt Date: Wed, 24 Apr 2019 22:28:09 -0400 Subject: [PATCH 3/3] removed logging statement --- airtime_mvc/application/services/PodcastService.php | 1 - 1 file changed, 1 deletion(-) diff --git a/airtime_mvc/application/services/PodcastService.php b/airtime_mvc/application/services/PodcastService.php index d9362ebde..587b85498 100644 --- a/airtime_mvc/application/services/PodcastService.php +++ b/airtime_mvc/application/services/PodcastService.php @@ -413,7 +413,6 @@ class Application_Service_PodcastService return null; } $child = $node->addChild($name, null, $namespace); - Logging::info($value); $child[0] = $value; return $child; }