From 0274920d145056c9cb74749783325c75e91fe356 Mon Sep 17 00:00:00 2001
From: Lucas Bickel <hairmare@rabe.ch>
Date: Fri, 24 Mar 2017 16:21:39 +0100
Subject: [PATCH] Restore datatables-library from server on login

When localStorage is empty we try getting the data from the server. This is a bit hacky since the ui uses a very old version of datatables.
---
 .../controllers/UsersettingsController.php    |  4 +++-
 .../public/js/airtime/library/library.js      | 22 ++++++++++++++-----
 2 files changed, 20 insertions(+), 6 deletions(-)

diff --git a/airtime_mvc/application/controllers/UsersettingsController.php b/airtime_mvc/application/controllers/UsersettingsController.php
index 519e854b8..635a24e40 100644
--- a/airtime_mvc/application/controllers/UsersettingsController.php
+++ b/airtime_mvc/application/controllers/UsersettingsController.php
@@ -47,7 +47,9 @@ class UsersettingsController extends Zend_Controller_Action
     {
         $data = Application_Model_Preference::getCurrentLibraryTableSetting();
         if (!is_null($data)) {
-            $this->view->settings = $data;
+            $this->_helper->json($data);
+        } else {
+            $this->_helper->json(false);
         }
     }
 
diff --git a/airtime_mvc/public/js/airtime/library/library.js b/airtime_mvc/public/js/airtime/library/library.js
index ba7a06066..c54fee9f7 100644
--- a/airtime_mvc/public/js/airtime/library/library.js
+++ b/airtime_mvc/public/js/airtime/library/library.js
@@ -651,14 +651,26 @@ var AIRTIME = (function(AIRTIME) {
             },
             "fnStateLoad": function fnLibStateLoad(oSettings) {
                 var settings = JSON.parse(localStorage.getItem('datatables-library'));
+
+                // local storage was empty lets get something from the backend
+                if (settings === null) {
+                    // we have a datatables implementation that is so old we need to async:false ;(
+                    // see http://legacy.datatables.net/usage/callbacks#fnStateLoad for info and
+                    // feel free to start trying to port this to a modern version ;)
+                    $.ajax({
+                        'url': baseUrl + 'usersettings/get-library-datatable',
+                        'async': false, // <<< every sane browser will warn that this is not nice
+                        'dataType': 'json',
+                        'success': function(oData) {
+                            localStorage.setItem('datatables-library', JSON.stringify(oData));
+                            settings = oData;
+                        }
+                    });
+                }
                 // Hacky; always set the visibility of the last column (actions buttons) to true
                 if (settings && settings.abVisCols) settings.abVisCols[settings.abVisCols.length - 1] = true;
 
-                try {
-                    return settings;
-                } catch (e) {
-                    return null;
-                }
+                return settings;
             },
             "fnStateLoadParams": function (oSettings, oData) {
                 var i,