feat(shared): remove unused abstract app (#1828)

This commit is contained in:
Jonas L 2022-05-04 14:12:06 +02:00 committed by GitHub
parent 3a2e910f12
commit 515a975e51
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 0 additions and 61 deletions

View File

@ -34,28 +34,6 @@ config = Config(filepath="/etc/libretime/config.yml")
> Don't instantiate a sub model if it has a required field, otherwise the `Config` class import will raise a `ValidationError`.
### App
Create an app class that inherit from `libretime_shared.app.AbstractApp`.
```py
from libretime_shared.app import AbstractApp
class LiquidsoapApp(AbstractApp):
name = "liquidsoap"
def __init__(self, some_arg, **kwargs):
super().__init__(**kwargs)
self.some_arg = some_arg
def run(self):
...
app = LiquidsoapApp(**kwargs)
app.run()
```
### CLI
Decorate your CLI commands with the shared decorators to add extra flags.

View File

@ -1,39 +0,0 @@
from abc import ABC, abstractmethod
from os import PathLike
from pathlib import Path
from typing import Optional
from loguru import logger
from .logging import LogLevel, level_from_name, setup_logger
# pylint: disable=too-few-public-methods
class AbstractApp(ABC):
"""
Abstracts the creation of an application to reduce boilerplate code such
as logging setup.
"""
log_level: LogLevel
log_filepath: Optional[Path] = None
@property
@abstractmethod
def name(self) -> str:
...
def __init__(
self,
*,
log_level: str,
log_filepath: Optional[PathLike] = None,
):
self.log_level = level_from_name(log_level)
if log_filepath is not None:
self.log_filepath = Path(log_filepath)
setup_logger(level=self.log_level, filepath=self.log_filepath)
logger.info(f"Starting {self.name}...")