From 8040d9a6c506a16bfc735336ebf5c3c9cdcea30b Mon Sep 17 00:00:00 2001 From: jo Date: Mon, 14 Feb 2022 09:37:14 +0100 Subject: [PATCH] feat(analyzer): do verify ssl certs on requests BREAKING CHANGE: Analyzer no longer ignore certificate verification when performing a request. We recommand using Letsencrypt to get a certificat. If you do rely on self signed certificat, please read the requests documentation to provide a CA Bundle to verify the cert using environement variables. --- analyzer/libretime_analyzer/status_reporter.py | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/analyzer/libretime_analyzer/status_reporter.py b/analyzer/libretime_analyzer/status_reporter.py index 1f1d568e7..7a029f53b 100644 --- a/analyzer/libretime_analyzer/status_reporter.py +++ b/analyzer/libretime_analyzer/status_reporter.py @@ -118,9 +118,7 @@ def send_http_request(picklable_request, retry_queue): bare_request = picklable_request.create_request() s = requests.Session() prepared_request = s.prepare_request(bare_request) - r = s.send( - prepared_request, timeout=StatusReporter._HTTP_REQUEST_TIMEOUT, verify=False - ) # SNI is a pain in the ass + r = s.send(prepared_request, timeout=StatusReporter._HTTP_REQUEST_TIMEOUT) r.raise_for_status() # Raise an exception if there was an http error code returned logger.info("HTTP request sent successfully.") except requests.exceptions.HTTPError as e: @@ -163,7 +161,7 @@ def is_web_server_broken(url): caused by Airtime or the webserver itself being broken temporarily. """ try: - test_req = requests.get(url, verify=False) + test_req = requests.get(url) test_req.raise_for_status() except Exception as e: return True