fix(deps): update dependency friendsofphp/php-cs-fixer to <3.17.1 (main) (#2556)

* fix(deps): update dependency friendsofphp/php-cs-fixer to <3.17.1

* style(legacy): format using php-cs-fixer

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: jo <ljonas@riseup.net>

legacy/application/common/DateHelper.php

@@ -434,7 +434,6 @@ class Application_Common_DateHelper
      *
      * Convert float seconds value to playlist time format
      *
-     * @param float $seconds
      * @param mixed $p_seconds
      *
      * @return string

legacy/application/common/enum/MediaType.php

@@ -12,6 +12,6 @@ final class MediaType
 
     public static function getDefault()
     {
-        return static::__default;
+        return self::__default;
     }
 }

legacy/application/controllers/ApiController.php

@@ -590,9 +590,6 @@ class ApiController extends Zend_Controller_Action
      * New API endpoint to display metadata from any single track.
      *
      * Find metadata to any track imported (eg. id=1&return=json)
-     *
-     * @param int    $id     track ID
-     * @param string $return json, artwork_data, or artwork
      */
     public function trackAction()
     {

legacy/application/models/Block.php

@@ -707,8 +707,6 @@ SQL;
     /**
      * Change fadeIn and fadeOut values for block Element.
      *
-     * @param int        $pos
-     *                            position of audioclip in block
      * @param string     $fadeIn
      *                            new value in ss.ssssss or extent format
      * @param string     $fadeOut
@@ -812,8 +810,6 @@ SQL;
     /**
      * Change cueIn/cueOut values for block element.
      *
-     * @param int    $pos
-     *                       position of audioclip in block
      * @param string $cueIn
      *                       new value in ss.ssssss or extent format
      * @param string $cueOut

legacy/application/models/Playlist.php

@@ -781,8 +781,6 @@ SQL;
     /**
      * Change cueIn/cueOut values for playlist element.
      *
-     * @param int    $pos
-     *                       position of audioclip in playlist
      * @param string $cueIn
      *                       new value in ss.ssssss or extent format
      * @param string $cueOut
@@ -1033,8 +1031,6 @@ SQL;
 
     /**
      * Delete all files from playlist.
-     *
-     * @param int $p_playlistId
      */
     public function deleteAllFilesFromPlaylist()
     {

legacy/application/models/Schedule.php

@@ -871,7 +871,6 @@ SQL;
      * @param array  $item     schedule info about one track
      * @param int    $media_id scheduled item's cc_files id
      * @param string $uri      path to the scheduled item's physical location
-     * @param int    $filsize  The file's file size in bytes
      * @param mixed  $filesize
      */
     private static function createFileScheduleEvent(&$data, $item, $media_id, $uri, $filesize)

legacy/application/models/Show.php

@@ -963,7 +963,6 @@ SQL;
      *                                  In UTC time
      * @param dateTime $end_timestamp
      *                                  In UTC time
-     * @param unknown_type $excludeInstance
      * @param bool     $onlyRecord
      * @param int      $showId
      *                                  limits the results to instances of a given showId only
@@ -1054,11 +1053,6 @@ SQL;
     }
 
     /**
-     * @param DateTime $start
-     *                             -in UTC time
-     * @param DateTime $end
-     *                             -in UTC time
-     * @param bool     $editable
      * @param mixed $p_start
      * @param mixed $p_end
      * @param mixed $p_editable

legacy/application/models/ShowInstance.php

@@ -234,8 +234,6 @@ SQL;
     /**
      * Add a playlist as the last item of the current show.
      *
-     * @param int   $plId
-     *                             Playlist ID
      * @param mixed $pl_id
      * @param mixed $checkUserPerm
      */
@@ -257,8 +255,6 @@ SQL;
     /**
      * Add a playlist as the first item of the current show.
      *
-     * @param int   $plId
-     *                             Playlist ID
      * @param mixed $pl_id
      * @param mixed $checkUserPerm
      */

legacy/application/models/StoredFile.php

@@ -247,10 +247,6 @@ class Application_Model_StoredFile
     /**
      * Set metadata element value.
      *
-     * @param string $category
-     *                           Metadata element by metadata constant
-     * @param string $value
-     *                           value to store, if NULL then delete record
      * @param mixed $p_category
      * @param mixed $p_value
      */
@@ -264,10 +260,6 @@ class Application_Model_StoredFile
     /**
      * Set metadata element value.
      *
-     * @param string $category
-     *                           Metadata element by db column
-     * @param string $value
-     *                           value to store, if NULL then delete record
      * @param mixed $p_category
      * @param mixed $p_value
      */
@@ -468,7 +460,6 @@ SQL;
      * This function is for when media monitor detects deletion of file
      * and trying to update airtime side.
      *
-     * @param bool  $p_deleteFile
      * @param mixed $deleteFromPlaylist
      */
     public function deleteByMediaMonitor($deleteFromPlaylist = false)

legacy/application/models/airtime/CcShowDays.php

@@ -39,8 +39,6 @@ class CcShowDays extends BaseCcShowDays
 
     /**
      * Returns the end of a show in the timezone it was created in.
-     *
-     * @param DateTime $startDateTime first show in show's local time
      */
     public function getLocalEndDateAndTime()
     {

legacy/application/services/ShowFormService.php

@@ -469,7 +469,6 @@ class Application_Service_ShowFormService
     /**
      * Enter description here ...
      *
-     * @param DateTime $showStart   user's local time
      * @param mixed $p_showStart
      */
     private function hasShowStarted($p_showStart)
@@ -660,7 +659,6 @@ class Application_Service_ShowFormService
      *
      * @param       $date        String
      * @param       $time        String
-     * @param $timezone String
      * @param mixed $newTimezone
      * @param mixed $oldTimezone
      */

legacy/application/services/ShowService.php

@@ -529,8 +529,6 @@ SQL;
      * - Update start and end time
      *
      * @param $showData edit show form values in raw form
-     * @param $isRecorded value computed from the edit show form
-     * @param $repeatType value computed from the edit show form
      */
     private function delegateInstanceCleanup($showData)
     {
@@ -1088,7 +1086,6 @@ SQL;
     /**
      * Updates the start and end time for cc_show_instances.
      *
-     * @param $showData edit show form data
      * @param mixed $diff
      */
     private function updateInstanceStartEndTime($diff)
@@ -1205,7 +1202,6 @@ SQL;
      * @param unknown_type $showDay
      * @param unknown_type $populateUntil
      * @param unknown_type $repeatInterval
-     * @param unknown_type $isRebroadcast
      * @param mixed        $repeatType
      * @param null|mixed   $daysAdded
      */
@@ -1426,7 +1422,6 @@ SQL;
      * i.e. second monday of each month.
      *
      * @param string $showStart
-     * @param string $timezone  user's local timezone
      */
     public static function getMonthlyWeeklyRepeatInterval($showStart)
     {
@@ -1646,7 +1641,6 @@ SQL;
     /**
      * Sets the fields for a cc_show table row.
      *
-     * @param $ccShow
      * @param mixed $showData
      */
     public function setCcShow($showData)
@@ -1691,11 +1685,6 @@ SQL;
     /**
      * Sets the fields for a cc_show_days table row.
      *
-     * @param $showId
-     * @param $userId
-     * @param $repeatType
-     * @param $isRecorded
-     * @param $showDay ccShowDay object we are setting values on
      * @param mixed $showData
      */
     private function setCcShowDays($showData)
@@ -1824,9 +1813,6 @@ SQL;
     /**
      * Sets the fields for a cc_show_rebroadcast table row.
      *
-     * @param $showId
-     * @param $repeatType
-     * @param $isRecorded
      * @param mixed $showData
      */
     private function setCcShowRebroadcasts($showData)
@@ -1873,7 +1859,6 @@ SQL;
     /**
      * Sets the fields for a cc_show_hosts table row.
      *
-     * @param $showId
      * @param mixed $showData
      */
     private function setCcShowHosts($showData)
@@ -1911,7 +1896,6 @@ SQL;
      *
      * @param DateTime $showStart user's local time
      * @param string   $duration  time interval (h)h:(m)m(:ss)
-     * @param string   $timezone  "Europe/Prague"
      * @param array    $offset    (days, hours, mins) used for rebroadcast shows
      *
      * @return array of 2 DateTime objects, start/end time of the show in UTC

legacy/tools/composer.json

@@ -1,6 +1,6 @@
 {
   "require": {
     "php": "^7.4",
-    "friendsofphp/php-cs-fixer": "<3.16.1"
+    "friendsofphp/php-cs-fixer": "<3.17.1"
   }
 }