From c3b62036286b6764df1222f930728406ced8865a Mon Sep 17 00:00:00 2001 From: Yuchen Wang Date: Fri, 9 Dec 2011 13:42:03 -0500 Subject: [PATCH] CC-3168: Stream Settings: "Vorbis Metadata" confusing string Done --- .../application/forms/StreamSetting.php | 9 +++++ .../scripts/preference/stream-setting.phtml | 7 +++- airtime_mvc/public/css/images/icon_info.png | Bin 0 -> 347 bytes .../public/css/images/tooltip_arrow.png | Bin 0 -> 171 bytes airtime_mvc/public/css/styles.css | 34 ++++++++++++++++++ 5 files changed, 49 insertions(+), 1 deletion(-) create mode 100644 airtime_mvc/public/css/images/icon_info.png create mode 100644 airtime_mvc/public/css/images/tooltip_arrow.png diff --git a/airtime_mvc/application/forms/StreamSetting.php b/airtime_mvc/application/forms/StreamSetting.php index afabcd9dd..b54a36393 100644 --- a/airtime_mvc/application/forms/StreamSetting.php +++ b/airtime_mvc/application/forms/StreamSetting.php @@ -38,8 +38,17 @@ class Application_Form_StreamSetting extends Zend_Form $this->addElement($output_type); } + # tooltip + $description = 'VLC and mplayer have a serious bug when playing an OGG/VORBIS + stream that has metadata information enabled (stream metadata is the + track title, show name, etc displayed in the audio player): they will + disconnect from the stream after every song if this option is enabled. + If your listeners do not require support for these audio players, + then you should enable this option.'; + $icecast_vorbis_metadata = new Zend_Form_Element_Checkbox('icecast_vorbis_metadata'); $icecast_vorbis_metadata->setLabel('Icecast Vorbis Metadata') + ->setDescription($description) ->setRequired(false) ->setValue(($setting['icecast_vorbis_metadata'] == "true")?1:0) ->setDecorators(array('ViewHelper')); diff --git a/airtime_mvc/application/views/scripts/preference/stream-setting.phtml b/airtime_mvc/application/views/scripts/preference/stream-setting.phtml index 9ffabfee2..470b0845c 100644 --- a/airtime_mvc/application/views/scripts/preference/stream-setting.phtml +++ b/airtime_mvc/application/views/scripts/preference/stream-setting.phtml @@ -31,7 +31,12 @@
diff --git a/airtime_mvc/public/css/images/icon_info.png b/airtime_mvc/public/css/images/icon_info.png new file mode 100644 index 0000000000000000000000000000000000000000..600e15d2359d09ea17d579b65b6d82b3b105c795 GIT binary patch literal 347 zcmV-h0i^zkP)v+iA7mpi^{Br*4rbIz{vWB9`cRd53AtJp2srJCFCzOezdR zOOgl1pb1=#y}$;{!ChRmB~u$*!ALTZ3ZMrrV4xbwv<6x0UsHyZ0SnL-MwbIR?HE}! zo9l3EIfL<_iBaVVRcvUIEszIAaMI-KHg8ham*=HL+<2p^JVz5u^Lgg8rkjB(J~VOh zc0QH>mf*~(Nh@R(YsMaTs_&G7?fRANX t!UZDrug3gt0e2xUY6VJQDS|%%1_0SoFmN!3FRK6m002ovPDHLkV1m*-iNF8= literal 0 HcmV?d00001 diff --git a/airtime_mvc/public/css/images/tooltip_arrow.png b/airtime_mvc/public/css/images/tooltip_arrow.png new file mode 100644 index 0000000000000000000000000000000000000000..7aed7701e607412739779c89c0e7c43a2939dc21 GIT binary patch literal 171 zcmeAS@N?(olHy`uVBq!ia0vp^96-#^!3-qdU8!RPQj#UE5hcO-X(i=}MX3yqDfvmM z3ZA)%>8U}fi7AzZCsS>Jir4~tLRs6|kDfdF6)3_~666>BpW*3t11}&?*VDx@ zq~ey#*@K)64je}g#QgWwmNBeza|yqvA0XlyxMi28b?nsOqW#;X8QB>4=QCK|cqp