From e730959e9f7cc1488fc90f62cfcab5f820d55160 Mon Sep 17 00:00:00 2001 From: jo Date: Mon, 27 Jun 2022 17:13:05 +0200 Subject: [PATCH] chore(api): rename editor role to host --- api/libretime_api/core/models/role.py | 2 +- .../core/tests/models/test_user.py | 2 +- api/libretime_api/permission_constants.py | 4 ++-- api/libretime_api/permissions.py | 2 +- api/libretime_api/tests/test_permissions.py | 22 +++++++++---------- 5 files changed, 16 insertions(+), 16 deletions(-) diff --git a/api/libretime_api/core/models/role.py b/api/libretime_api/core/models/role.py index 3710fe077..98abd53a6 100644 --- a/api/libretime_api/core/models/role.py +++ b/api/libretime_api/core/models/role.py @@ -3,6 +3,6 @@ from django.db import models class Role(models.TextChoices): GUEST = "G", "Guest" - EDITOR = "H", "Editor" + HOST = "H", "Host" MANAGER = "P", "Manager" ADMIN = "A", "Admin" diff --git a/api/libretime_api/core/tests/models/test_user.py b/api/libretime_api/core/tests/models/test_user.py index 4f4538782..7ab720e7b 100644 --- a/api/libretime_api/core/tests/models/test_user.py +++ b/api/libretime_api/core/tests/models/test_user.py @@ -7,7 +7,7 @@ from ...models import Role, User class TestUserManager(APITestCase): def test_create_user(self): user = User.objects.create_user( - role=Role.EDITOR, + role=Role.HOST, username="test", password="test", email="test@example.com", diff --git a/api/libretime_api/permission_constants.py b/api/libretime_api/permission_constants.py index fee0f09e7..01890e24a 100644 --- a/api/libretime_api/permission_constants.py +++ b/api/libretime_api/permission_constants.py @@ -19,7 +19,7 @@ GUEST_PERMISSIONS = [ "view_apiroot", ] -EDITOR_PERMISSIONS = GUEST_PERMISSIONS + [ +HOST_PERMISSIONS = GUEST_PERMISSIONS + [ "add_file", "add_podcast", "add_podcastepisode", @@ -100,6 +100,6 @@ MANAGER_PERMISSIONS = GUEST_PERMISSIONS + [ GROUPS = { Role.GUEST.value: GUEST_PERMISSIONS, - Role.EDITOR.value: EDITOR_PERMISSIONS, + Role.HOST.value: HOST_PERMISSIONS, Role.MANAGER.value: MANAGER_PERMISSIONS, } diff --git a/api/libretime_api/permissions.py b/api/libretime_api/permissions.py index f358dbb40..bf89ebb21 100644 --- a/api/libretime_api/permissions.py +++ b/api/libretime_api/permissions.py @@ -18,7 +18,7 @@ REQUEST_PERMISSION_TYPE_MAP = { def get_own_obj(request, view): user = request.user - if user is None or user.role != Role.EDITOR: + if user is None or user.role != Role.HOST: return "" if request.method == "GET": return "" diff --git a/api/libretime_api/tests/test_permissions.py b/api/libretime_api/tests/test_permissions.py index f3a7a44bf..a3aa205e9 100644 --- a/api/libretime_api/tests/test_permissions.py +++ b/api/libretime_api/tests/test_permissions.py @@ -97,12 +97,12 @@ class TestPermissions(APITestCase): msg=f"Invalid for model {model}", ) - def test_editor_get_permissions(self): + def test_host_get_permissions(self): for model in self.URLS: response = self.logged_in_test_model( model, - Role.EDITOR, - "editor", + Role.HOST, + "host", self.client.get, ) self.assertEqual( @@ -111,10 +111,10 @@ class TestPermissions(APITestCase): msg=f"Invalid for model {model}", ) - def test_editor_post_permissions(self): + def test_host_post_permissions(self): user = get_user_model().objects.create_user( - role=Role.EDITOR, - username="editor2", + role=Role.HOST, + username="host2", password="test", email="test@example.com", first_name="test", @@ -123,14 +123,14 @@ class TestPermissions(APITestCase): file = baker.make("storage.File", owner=user) model = f"files/{file.id}" path = self.path.format(model) - self.client.login(username="editor2", password="test") + self.client.login(username="host2", password="test") response = self.client.patch(path, {"name": "newFilename"}) self.assertEqual(response.status_code, 200) - def test_editor_post_permissions_failure(self): + def test_host_post_permissions_failure(self): get_user_model().objects.create_user( - role=Role.EDITOR, - username="editor2", + role=Role.HOST, + username="host2", password="test", email="test@example.com", first_name="test", @@ -139,6 +139,6 @@ class TestPermissions(APITestCase): file = baker.make("storage.File") model = f"files/{file.id}" path = self.path.format(model) - self.client.login(username="editor2", password="test") + self.client.login(username="host2", password="test") response = self.client.patch(path, {"name": "newFilename"}) self.assertEqual(response.status_code, 403)