CC-2434: Install script recreates unique ID on every install. Moved ID creation into the database install script.

install/include/AirtimeInstall.php

@@ -265,17 +265,18 @@ class AirtimeInstall
         return true;
     }
     
-    public static function SetUniqueId(){
-    	global $CC_DBC;
-    	
-    	$uniqueId = md5(uniqid("", true));
-    	
-    	$sql = "INSERT INTO cc_pref (keystr, valstr) VALUES ('uniqueId', '$uniqueId')";
+    public static function SetUniqueId()
+    {
+        global $CC_DBC;
+
+        $uniqueId = md5(uniqid("", true));
+
+        $sql = "INSERT INTO cc_pref (keystr, valstr) VALUES ('uniqueId', '$uniqueId')";
         $result = $CC_DBC->query($sql);
         if (PEAR::isError($result)) {
             return false;
         }
-        return true;	
+        return true;
     }
 
     public static function GetAirtimeVersion()

install/include/airtime-db-install.php

@@ -47,6 +47,8 @@ if (isset($argv[1]) && $argv[1] == 'y') {
 echo "* Setting Airtime version".PHP_EOL;
 AirtimeInstall::SetAirtimeVersion(AIRTIME_VERSION);
 
+AirtimeInstall::SetUniqueId();
+
 if (AirtimeInstall::$databaseTablesCreated) {
   echo "* Inserting stor directory into music_dirs table".PHP_EOL;
   $stor_dir = realpath($CC_CONFIG['storageDir']);

install/include/airtime-install.php

@@ -147,8 +147,6 @@ AirtimeInstall::CreateSymlinksToUtils();
 
 AirtimeInstall::CreateZendPhpLogFile();
 
-AirtimeInstall::SetUniqueId();
-
 // Create CRON task to run every day.  Time of day is initialized to a random time.
 $hour = rand(0,23);
 $minute = rand(0,59);