Congegni/sintonia
7
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

CC-5840: Add Media -> Endless retries if there is a validation error

Browse source 
Fixed by not adding message to retry queue if request returns a
validation specific error code (422)
This commit is contained in:
drigato 2014-05-08 13:01:49 -04:00
parent c291439483
commit 0040965222
2 changed files with 8 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
airtime_mvc/application/modules/rest/controllers/MediaController.php
View file

@ -369,7 +369,7 @@ class Rest_MediaController extends Zend_Rest_Controller
private function invalidDataResponse()
{
$resp = $this->getResponse();
$resp->setHttpResponseCode(400);
$resp->setHttpResponseCode(422);
$resp->appendBody("ERROR: Invalid data");
}

10
python_apps/airtime_analyzer/airtime_analyzer/status_reporter.py
View file

@ -91,9 +91,13 @@ def send_http_request(picklable_request, retry_queue):
r.raise_for_status() # Raise an exception if there was an http error code returned
logging.info("HTTP request sent successfully.")
except requests.exceptions.RequestException as e:
# If the web server is having problems, retry the request later:
logging.error("HTTP request failed. Retrying later! Exception was: %s" % str(e))
retry_queue.append(picklable_request)
if r.status_code != 422:
# If the web server is having problems, retry the request later:
logging.error("HTTP request failed. Retrying later! Exception was: %s" % str(e))
retry_queue.append(picklable_request)
else:
# Do no retry the request if there was a metadata validation error
logging.error("HTTP request failed. Exception was: %s" % str(e))
except Exception as e:
logging.error("HTTP request failed with unhandled exception. %s" % str(e))
# Don't put the request into the retry queue, just give up on this one.