Merge branch '2.2.x' of dev.sourcefabric.org:airtime into 2.2.x

python_apps/api_clients/api_client.py

@@ -20,6 +20,11 @@ import traceback
 
 AIRTIME_VERSION = "2.2.0"
 
+
+# TODO : Place these functions in some common module. Right now, media
+# monitor uses the same functions and it would be better to reuse them
+# instead of copy pasting them around
+
 def to_unicode(obj, encoding='utf-8'):
     if isinstance(obj, basestring):
         if not isinstance(obj, unicode):
@@ -39,7 +44,7 @@ def convert_dict_value_to_utf8(md):
 # Airtime API Client
 ################################################################################
 
-class AirtimeApiClient():
+class AirtimeApiClient(object):
 
     # This is a little hacky fix so that I don't have to pass the config object
     # everywhere where AirtimeApiClient needs to be initialized
@@ -422,15 +427,13 @@ class AirtimeApiClient():
 
     def send_media_monitor_requests(self, action_list, dry=False):
         """
-        Send a gang of media monitor events at a time. actions_list is a list
+        Send a gang of media monitor events at a time. actions_list is a
-        of dictionaries where every dictionary is representing an action. Every
+        list of dictionaries where every dictionary is representing an
-        action dict must contain a 'mode' key that says what kind of action it
+        action. Every action dict must contain a 'mode' key that says
-        is and an optional 'is_record' key that says whether the show was
+        what kind of action it is and an optional 'is_record' key that
-        recorded or not. The value of this key does not matter, only if it's
+        says whether the show was recorded or not. The value of this key
-        present or not.
+        does not matter, only if it's present or not.
         """
-        logger = self.logger
-        try:
         url = self.construct_url('reload_metadata_group')
         # We are assuming that action_list is a list of dictionaries such
         # that every dictionary represents the metadata of a file along
@@ -464,11 +467,6 @@ class AirtimeApiClient():
         response = self.get_response_from_server(req)
         response = json.loads(response)
         return response
-        except ValueError: raise
-        except Exception, e:
-            logger.error('Exception: %s', e)
-            logger.error("traceback: %s", traceback.format_exc())
-            raise
 
     #returns a list of all db files for a given directory in JSON format:
     #{"files":["path/to/file1", "path/to/file2"]}

python_apps/pypo/pyponotify.py

@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+import traceback
 
 """
 Python part of radio playout (pypo)
@@ -102,6 +103,24 @@ class Notify:
         logger.debug('# Calling server to update webstream data       #')
         logger.debug('#################################################')
         response = self.api_client.notify_webstream_data(data, media_id)
+        logger.debug("Response: " + json.dumps(response))
+
+    def run_with_options(self, options):
+        if options.error and options.stream_id:
+            self.notify_liquidsoap_status(options.error, options.stream_id, options.time)
+        elif options.connect and options.stream_id:
+            self.notify_liquidsoap_status("OK", options.stream_id, options.time)
+        elif options.source_name and options.source_status:
+            self.notify_source_status(options.source_name, options.source_status)
+        elif options.webstream:
+            self.notify_webstream_data(options.webstream, options.media_id)
+        elif options.media_id:
+            self.notify_media_start_playing(options.media_id)
+        elif options.liquidsoap_started:
+            self.notify_liquidsoap_started()
+        else:
+            logger.debug("Unrecognized option in options(%s). Doing nothing" \
+                  % str(options))
 
 
 if __name__ == '__main__':
@@ -112,41 +131,9 @@ if __name__ == '__main__':
     print '#########################################'
 
     # initialize
-    if options.error and options.stream_id:
     try:
         n = Notify()
-            n.notify_liquidsoap_status(options.error, options.stream_id, options.time)
+        n.run_with_options(options)
-        except Exception, e:
+    except Exception as e:
-            print e
+        print( traceback.format_exc() )
-    elif options.connect and options.stream_id:
-        try:
-            n = Notify()
-            n.notify_liquidsoap_status("OK", options.stream_id, options.time)
-        except Exception, e:
-            print e
-    elif options.source_name and options.source_status:
-        try:
-            n = Notify()
-            n.notify_source_status(options.source_name, options.source_status)
-        except Exception, e:
-            print e
-    elif options.webstream:
-        try:
-            n = Notify()
-            n.notify_webstream_data(options.webstream, options.media_id)
-        except Exception, e:
-            print e
-    elif options.media_id:
-
-        try:
-            n = Notify()
-            n.notify_media_start_playing(options.media_id)
-        except Exception, e:
-            print e
-    elif options.liquidsoap_started:
-        try:
-            n = Notify()
-            n.notify_liquidsoap_started()
-        except Exception, e:
-            print e