CC-2873: Soundcloud plugin doesn't log any error when there is an error

with soundcloud uploading through api controller

- Changed constant names
- added -1 constant

airtime_mvc/application/configs/constants.php

@@ -37,5 +37,6 @@ define('UI_PLAYLIST_SESSNAME', 'PLAYLIST');
 
 
 // Soundcloud contants
-define('SC_PROGRESS', -2);
-define('SC_ERROR', -2);
+define('SOUNDCLOUD_NULL', -1);
+define('SOUNDCLOUD_PROGRESS', -2);
+define('SOUNDCLOUD_ERROR', -3);

airtime_mvc/application/controllers/ApiController.php

@@ -413,7 +413,7 @@ class ApiController extends Zend_Controller_Action
                     $this->setSoundCloudErrorCode($code);
                     $this->setSoundCloudErrorMsg($msg);
                     // setting sc id to -3 which indicates error
-                    $this->setSoundCloudFileId(SC_ERROR);
+                    $this->setSoundCloudFileId(SOUNDCLOUD_ERROR);
         			if(!in_array($code, array(0, 100))) {
         				break;
         			}

utils/soundcloud-uploader.php

@@ -60,6 +60,6 @@ if(count($argv) != 2){
 $id = $argv[1];
 $file = Application_Model_StoredFile::Recall($id);
 // set id with -2 which is indicator for processing
-$file->setSoundCloudFileId(SC_PROGRESS);
+$file->setSoundCloudFileId(SOUNDCLOUD_PROGRESS);
 $file->uploadToSoundCloud();