CC-5823: Airtime Analyzer: Wav file uploading fails with zero length and

empty mime

* Fixed
This commit is contained in:
Albert Santoni 2014-04-30 18:32:17 -04:00
parent c2f6032c8b
commit 26a39ed2db
2 changed files with 25 additions and 30 deletions

View File

@ -1,6 +1,8 @@
import time import time
import datetime import datetime
import mutagen import mutagen
import magic
import wave
import logging import logging
from analyzer import Analyzer from analyzer import Analyzer
@ -24,6 +26,11 @@ class MetadataAnalyzer(Analyzer):
#Other fields we'll want to set for Airtime: #Other fields we'll want to set for Airtime:
metadata["hidden"] = False metadata["hidden"] = False
# Mutagen doesn't handle WAVE files so we use a different package
mime_check = magic.from_file(filename, mime=True)
if mime_check == 'audio/x-wav':
return MetadataAnalyzer._analyze_wave(filename, metadata)
#Extract metadata from an audio file using mutagen #Extract metadata from an audio file using mutagen
audio_file = mutagen.File(filename, easy=True) audio_file = mutagen.File(filename, easy=True)
@ -122,33 +129,20 @@ class MetadataAnalyzer(Analyzer):
return metadata return metadata
@staticmethod
def _analyze_wave(filename, metadata):
''' try:
For reference, the Airtime metadata fields are: reader = wave.open(filename, 'rb')
title metadata["mime"] = magic.from_file(filename, mime=True)
artist ("Creator" in Airtime) metadata["channels"] = reader.getnchannels()
album metadata["sample_rate"] = reader.getframerate()
bit rate length_seconds = float(reader.getnframes()) / float(metadata["channels"] * metadata["sample_rate"])
BPM #Converting the length in seconds (float) to a formatted time string
composer track_length = datetime.timedelta(seconds=length_seconds)
conductor metadata["length"] = str(track_length) #time.strftime("%H:%M:%S.%f", track_length)
copyright metadata["length_seconds"] = length_seconds
cue in metadata["cueout"] = metadata["length"]
cue out except wave.Error:
encoded by logging.error("Invalid WAVE file.")
genre raise
ISRC return metadata
label
language
last modified
length
mime
mood
owner
replay gain
sample rate
track number
website
year
'''

View File

@ -23,6 +23,7 @@ setup(name='airtime_analyzer',
install_requires=[ install_requires=[
'mutagen', 'mutagen',
'pika', 'pika',
'magic',
'nose', 'nose',
'coverage', 'coverage',
'mock', 'mock',