From 38513c3bed43b00b09b7f48a434ff178ff871f02 Mon Sep 17 00:00:00 2001
From: jo <ljonas@riseup.net>
Date: Mon, 16 Aug 2021 14:04:15 +0200
Subject: [PATCH] Add shell-check job

We don't want to fail on shellcheck yet.
---
 .github/workflows/test.yml | 21 +++++++++++++++++++++
 Makefile                   |  2 +-
 2 files changed, 22 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index 47022fa83..333517402 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -25,6 +25,27 @@ jobs:
       - uses: actions/setup-python@v2
       - uses: pre-commit/action@v2.0.3
 
+  check-shell:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - uses: actions/setup-python@v2
+      - run: |
+          python -m venv venv && source venv/bin/activate
+          pip install gh-release-install
+
+          sudo venv/bin/gh-release-install \
+            koalaman/shellcheck \
+            shellcheck-{tag}.linux.x86_64.tar.xz --extract shellcheck-{tag}/shellcheck \
+            /usr/bin/shellcheck
+
+          sudo venv/bin/gh-release-install \
+            mvdan/sh \
+            shfmt_{tag}_linux_amd64 \
+            /usr/bin/shfmt
+
+      - run: make shell-check
+
   test:
     strategy:
       matrix:
diff --git a/Makefile b/Makefile
index ef15c9b57..fc8e65144 100644
--- a/Makefile
+++ b/Makefile
@@ -13,4 +13,4 @@ shell-format:
 
 shell-check:
 	shfmt -f . | xargs shfmt -i 2 -ci -sr -kp -d
-	shfmt -f . | xargs shellcheck --color=always
+	shfmt -f . | xargs shellcheck --color=always || true