Start linting with mypy

api/Makefile

@@ -4,6 +4,7 @@ include ../tools/python.mk
 
 PIP_INSTALL := --editable .[dev]
 PYLINT_ARG := libretimeapi
+MYPY_ARG := libretimeapi
 
-lint: .pylint
+lint: .pylint .mypy
 clean: .clean

api/setup.py

@@ -34,6 +34,7 @@ setup(
         ],
         "dev": [
             "psycopg2-binary",
+            "mypy",
             "pylint",
         ],
     },

python_apps/airtime-celery/Makefile

@@ -4,6 +4,7 @@ include ../../tools/python.mk
 
 PIP_INSTALL := --editable .[dev]
 PYLINT_ARG := airtime-celery
+MYPY_ARG := airtime-celery
 
-lint: .pylint
+lint: .pylint .mypy
 clean: .clean

python_apps/airtime-celery/setup.py

@@ -26,6 +26,7 @@ setup(
     extras_require={
         "prod": [],
         "dev": [
+            "mypy",
             "pylint",
         ],
     },

python_apps/airtime_analyzer/Makefile

@@ -4,9 +4,10 @@ include ../../tools/python.mk
 
 PIP_INSTALL := --editable .[dev]
 PYLINT_ARG := airtime_analyzer tests
+MYPY_ARG := airtime_analyzer tests
 PYTEST_ARG := --cov=airtime_analyzer tests
 
-lint: .pylint
+lint: .pylint .mypy
 
 fixtures:
 	bash tests/fixtures/generate.sh

python_apps/airtime_analyzer/setup.py

@@ -37,6 +37,7 @@ setup(
         "prod": [],
         "dev": [
             "distro",
+            "mypy",
             "pylint",
             "pytest",
             "pytest-cov",

python_apps/api_clients/Makefile

@@ -4,8 +4,9 @@ include ../../tools/python.mk
 
 PIP_INSTALL := --editable .[dev]
 PYLINT_ARG := api_clients tests
+MYPY_ARG := api_clients tests
 PYTEST_ARG := --cov=api_clients tests
 
-lint: .pylint
+lint: .pylint .mypy
 test: .pytest
 clean: .clean

python_apps/api_clients/setup.py

@@ -26,6 +26,7 @@ setup(
     extras_require={
         "prod": [],
         "dev": [
+            "mypy",
             "pylint",
             "pytest",
             "pytest-cov",

python_apps/pypo/Makefile

@@ -4,6 +4,7 @@ include ../../tools/python.mk
 
 PIP_INSTALL := --editable .[dev]
 PYLINT_ARG := liquidsoap pypo
+MYPY_ARG := liquidsoap pypo
 
-lint: .pylint
+lint: .pylint .mypy
 clean: .clean

python_apps/pypo/setup.py

@@ -40,6 +40,7 @@ setup(
     extras_require={
         "prod": [],
         "dev": [
+            "mypy",
             "pylint",
         ],
     },

tools/Makefile

@@ -4,8 +4,9 @@ include python.mk
 
 PIP_INSTALL := -r requirements-dev.txt
 PYLINT_ARG := tools
+MYPY_ARG := .
 PYTEST_ARG := .
 
-lint: .pylint
+lint: .pylint .mypy
 test: .pytest
 clean: .clean

tools/python.mk

@@ -5,6 +5,7 @@ CPU_CORES := $(shell nproc)
 
 # PIP_INSTALL := --editable .[dev]
 # PYLINT_ARG :=
+# MYPY_ARG :=
 # PYTEST_ARG :=
 
 VENV := venv
@@ -19,6 +20,11 @@ $(VENV):
 	source $(VENV)/bin/activate
 	pylint --output-format=colorized $(PYLINT_ARG) || true
 
+.PHONY: .mypy
+.mypy: $(VENV)
+	source $(VENV)/bin/activate
+	mypy $(MYPY_ARG) || true
+
 .PHONY: .pytest
 .pytest: $(VENV)
 	source venv/bin/activate

tools/requirements-dev.txt

@@ -1,3 +1,4 @@
+mypy
 pylint
 pytest
 pytest-xdist