From 4db93d3cee136435b4c12dfa4ec623e206a3876b Mon Sep 17 00:00:00 2001 From: Robbt Date: Thu, 9 May 2019 10:46:39 -0400 Subject: [PATCH] remove commented out code and add comment about sort null addition --- airtime_mvc/application/models/Block.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/airtime_mvc/application/models/Block.php b/airtime_mvc/application/models/Block.php index a6e486746..f40945742 100644 --- a/airtime_mvc/application/models/Block.php +++ b/airtime_mvc/application/models/Block.php @@ -1750,7 +1750,6 @@ SQL; $qry->add("file_exists", "true", Criteria::EQUAL); $qry->add("hidden", "false", Criteria::EQUAL); - //$qry->addAsColumn('lptime','COALESCE("lptime",\'1970-01-01\')'); $sortTracks = 'random'; if (isset($storedCrit['sort'])) { $sortTracks = $storedCrit['sort']['value']; @@ -1761,6 +1760,7 @@ SQL; else if ($sortTracks == 'oldest') { $qry->addAscendingOrderByColumn('utime'); } + // these sort additions are needed to override the default postgres NULL sort behavior else if ($sortTracks == 'mostrecentplay') { $qry->addDescendingOrderByColumn('(lptime IS NULL), lptime'); }