From 50ece038c29946d5c08f1048a4a9bb00dfe7694b Mon Sep 17 00:00:00 2001
From: Martin Konecny <martin.konecny@gmail.com>
Date: Tue, 28 May 2013 17:45:09 -0400
Subject: [PATCH] fix errors reported by Facebook's scheck

-controller dir
---
 airtime_mvc/application/controllers/ErrorController.php      | 2 +-
 airtime_mvc/application/controllers/PreferenceController.php | 2 ++
 airtime_mvc/application/controllers/ScheduleController.php   | 1 +
 airtime_mvc/application/controllers/UserController.php       | 1 +
 4 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/airtime_mvc/application/controllers/ErrorController.php b/airtime_mvc/application/controllers/ErrorController.php
index 0a4fee725..70829db63 100644
--- a/airtime_mvc/application/controllers/ErrorController.php
+++ b/airtime_mvc/application/controllers/ErrorController.php
@@ -24,7 +24,7 @@ class ErrorController extends Zend_Controller_Action
         }
 
         // Log exception, if logger available
-        if ($log = $this->getLog()) {
+        if (($log = $this->getLog())) {
             $log->crit($this->view->message, $errors->exception);
         }
 
diff --git a/airtime_mvc/application/controllers/PreferenceController.php b/airtime_mvc/application/controllers/PreferenceController.php
index 7d0f21210..40755d558 100644
--- a/airtime_mvc/application/controllers/PreferenceController.php
+++ b/airtime_mvc/application/controllers/PreferenceController.php
@@ -32,6 +32,7 @@ class PreferenceController extends Zend_Controller_Action
         $this->view->statusMsg = "";
 
         $form = new Application_Form_Preferences();
+        $values = array();
 
         if ($request->isPost()) {
             $params = $request->getPost();
@@ -223,6 +224,7 @@ class PreferenceController extends Zend_Controller_Action
             $s1_data = array();
             $s2_data = array();
             $s3_data = array();
+            $values = array();
             foreach($postData as $k=>$v) {
                 $v = explode('=', urldecode($v));
                 if (strpos($v[0], "s1_data") !== false) {
diff --git a/airtime_mvc/application/controllers/ScheduleController.php b/airtime_mvc/application/controllers/ScheduleController.php
index b87018165..b610063af 100644
--- a/airtime_mvc/application/controllers/ScheduleController.php
+++ b/airtime_mvc/application/controllers/ScheduleController.php
@@ -600,6 +600,7 @@ class ScheduleController extends Zend_Controller_Action
 
         $baseUrl = $this->getRequest()->getBaseUrl();
         $url = $file->getRelativeFileUrl($baseUrl).'download/true';
+        $menu = array();
         $menu[] = array('action' => array('type' => 'gourl', 'url' => $url),
                             'title' => _('Download'));
 
diff --git a/airtime_mvc/application/controllers/UserController.php b/airtime_mvc/application/controllers/UserController.php
index bfbe8a258..ddfd15c9c 100644
--- a/airtime_mvc/application/controllers/UserController.php
+++ b/airtime_mvc/application/controllers/UserController.php
@@ -41,6 +41,7 @@ class UserController extends Zend_Controller_Action
         if ($request->isPost()) {
             $params = $request->getPost();
             $postData = explode('&', $params['data']);
+            $formData = array();
             foreach($postData as $k=>$v) {
                 $v = explode('=', $v);
                 $formData[$v[0]] = urldecode($v[1]);