CC-5709: Airtime Analyzer

* Added unit test coverage report stuff
* Added more unit tests
* 98% test coverage :-)
* Fixed a few bugs and removed some dead code

python_apps/airtime_analyzer/tests/analyzer_pipeline_tests.py

@@ -2,11 +2,12 @@ from nose.tools import *
 import os
 import shutil
 import multiprocessing
+import Queue
 import datetime
 from airtime_analyzer.analyzer_pipeline import AnalyzerPipeline
 
 DEFAULT_AUDIO_FILE = u'tests/test_data/44100Hz-16bit-mono.mp3'
-DEFAULT_IMPORT_DEST = u'Test Artist/44100Hz-16bit-mono.mp3'
+DEFAULT_IMPORT_DEST = u'Test Artist/Test Album/44100Hz-16bit-mono.mp3'
 
 def setup():
     pass
@@ -32,3 +33,19 @@ def test_basic():
     assert results["length"] == str(datetime.timedelta(seconds=results["length_seconds"]))
     assert os.path.exists(DEFAULT_IMPORT_DEST)
 
+@raises(TypeError)
+def test_wrong_type_queue_param():
+    AnalyzerPipeline.run_analysis(Queue.Queue(), u'', u'', u'')
+
+@raises(TypeError)
+def test_wrong_type_string_param2():
+    AnalyzerPipeline.run_analysis(multiprocessing.queues.Queue(), '', u'', u'')
+
+@raises(TypeError)
+def test_wrong_type_string_param3():
+    AnalyzerPipeline.run_analysis(multiprocessing.queues.Queue(), u'', '', u'')
+
+@raises(TypeError)
+def test_wrong_type_string_param4():
+    AnalyzerPipeline.run_analysis(multiprocessing.queues.Queue(), u'', u'', '')
+

python_apps/airtime_analyzer/tests/metadata_analyzer_tests.py

@@ -1,5 +1,7 @@
 # -*- coding: utf-8 -*-
 import datetime
+import mutagen
+import mock
 from nose.tools import *
 from airtime_analyzer.metadata_analyzer import MetadataAnalyzer 
 
@@ -112,3 +114,36 @@ def test_mp3_utf8():
     assert metadata['mime'] == 'audio/mpeg'
     assert metadata['track_total'] == u'10' # MP3s can have a track_total
 
+# Make sure the parameter checking works
+@raises(TypeError)
+def test_move_wrong_string_param1():
+    not_unicode = 'asdfasdf'
+    MetadataAnalyzer.analyze(not_unicode, dict())
+
+@raises(TypeError)
+def test_move_wrong_metadata_dict():
+    not_a_dict = list()
+    MetadataAnalyzer.analyze(u'asdfasdf', not_a_dict)
+
+# Test an mp3 file where the number of channels is invalid or missing:
+def test_mp3_bad_channels():
+    filename = u'tests/test_data/44100Hz-16bit-mono.mp3'
+    ''' 
+        It'd be a pain in the ass to construct a real MP3 with an invalid number
+        of channels by hand because that value is stored in every MP3 frame in the file
+    '''
+    print "testing bad channels..."
+    audio_file = mutagen.File(filename, easy=True)
+    audio_file.info.mode = 1777
+    with mock.patch('airtime_analyzer.metadata_analyzer.mutagen') as mock_mutagen:
+        mock_mutagen.File.return_value = audio_file
+        #mock_mutagen.side_effect = lambda *args, **kw: audio_file #File(*args, **kw)
+
+    metadata = MetadataAnalyzer.analyze(filename, dict())
+    check_default_metadata(metadata)
+    assert metadata['channels'] == 1
+    assert metadata['bit_rate'] == 64000
+    assert metadata['length_seconds'] == 3.90925 
+    assert metadata['mime'] == 'audio/mpeg' # Not unicode because MIMEs aren't.
+    assert metadata['track_total'] == u'10' # MP3s can have a track_total
+    #Mutagen doesn't extract comments from mp3s it seems