From 6700b4b8e0a408a99d586576b2ce9c6c45622c1c Mon Sep 17 00:00:00 2001 From: jo Date: Sat, 29 May 2021 17:48:35 +0200 Subject: [PATCH] Extract common fixtures in conftest.py --- .../airtime_analyzer/tests/conftest.py | 20 +++++++++++++++++++ .../tests/filemover_analyzer_test.py | 17 +--------------- 2 files changed, 21 insertions(+), 16 deletions(-) create mode 100644 python_apps/airtime_analyzer/tests/conftest.py diff --git a/python_apps/airtime_analyzer/tests/conftest.py b/python_apps/airtime_analyzer/tests/conftest.py new file mode 100644 index 000000000..0b1cb7d10 --- /dev/null +++ b/python_apps/airtime_analyzer/tests/conftest.py @@ -0,0 +1,20 @@ +import pytest +import os +import tempfile +import shutil + +AUDIO_FILE = "tests/test_data/44100Hz-16bit-mono.mp3" +AUDIO_FILENAME = os.path.basename(AUDIO_FILE) + + +@pytest.fixture() +def dest_dir(): + with tempfile.TemporaryDirectory(prefix="dest") as tmpdir: + yield tmpdir + + +@pytest.fixture() +def src_dir(): + with tempfile.TemporaryDirectory(prefix="src") as tmpdir: + shutil.copy(AUDIO_FILE, tmpdir) + yield tmpdir diff --git a/python_apps/airtime_analyzer/tests/filemover_analyzer_test.py b/python_apps/airtime_analyzer/tests/filemover_analyzer_test.py index 87211d36a..28d681f44 100644 --- a/python_apps/airtime_analyzer/tests/filemover_analyzer_test.py +++ b/python_apps/airtime_analyzer/tests/filemover_analyzer_test.py @@ -6,9 +6,7 @@ import time import mock import pytest from airtime_analyzer.filemover_analyzer import FileMoverAnalyzer - -AUDIO_FILE = "tests/test_data/44100Hz-16bit-mono.mp3" -AUDIO_FILENAME = os.path.basename(AUDIO_FILE) +from .conftest import AUDIO_FILENAME def test_dont_use_analyze(): @@ -30,19 +28,6 @@ def test_move_wrong_params(params, exception): FileMoverAnalyzer.move(*params) -@pytest.fixture() -def dest_dir(): - with tempfile.TemporaryDirectory(prefix="dest") as tmpdir: - yield tmpdir - - -@pytest.fixture() -def src_dir(): - with tempfile.TemporaryDirectory(prefix="src") as tmpdir: - shutil.copy(AUDIO_FILE, tmpdir) - yield tmpdir - - def test_basic(src_dir, dest_dir): FileMoverAnalyzer.move( os.path.join(src_dir, AUDIO_FILENAME),