Congegni/sintonia
7
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

CC-3391: Audio Preview cannot play tracks with commas in their filename

Browse source 
- The content distribution header filename attribute, wasn't properly quoted for inline content. This causes a bug for files with comma names.
- changed the play button in library back to the speaker icon
- removed some dead code preview_player.js
- removed the file name attribute, will need better approch to presenting the user with audio information.
This commit is contained in:
Daniel 2012-03-06 13:50:07 -05:00
parent 348011dbc3
commit 709e117f41
8 changed files with 22 additions and 67 deletions
Download patch file Download diff file Expand all files Collapse all files

11
airtime_mvc/application/controllers/ApiController.php
View file

@ -116,10 +116,9 @@ class ApiController extends Zend_Controller_Action
return;
}
$name = $this->_getParam("name");
$filename = $this->_getParam("filename");
$file_id = substr($filename, 0, strpos($filename, "."));
$fileID = $this->_getParam("fileID");
$file_id = substr($fileID, 0, strpos($fileID, "."));
if (ctype_alnum($file_id) && strlen($file_id) == 32)
{
$media = Application_Model_StoredFile::RecallByGunid($file_id);
@ -132,7 +131,7 @@ class ApiController extends Zend_Controller_Action
$file_base_name = substr($file_base_name, 1);
// possibly use fileinfo module here in the future.
// http://www.php.net/manual/en/book.fileinfo.php
$ext = pathinfo($filename, PATHINFO_EXTENSION);
$ext = pathinfo($fileID, PATHINFO_EXTENSION);
//Download user left clicks a track and selects Download.
if ("true" == $this->_getParam('download')){
//path_info breaks up a file path into seperate pieces of informaiton.
@ -146,7 +145,7 @@ class ApiController extends Zend_Controller_Action
header('Content-Disposition: attachment; filename="'.$file_base_name.'"');
}else{
//user clicks play button for track and downloads it.
header("Content-Disposition: inline; filename=$file_base_name");
header('Content-Disposition: inline; filename="'.$file_base_name.'"');
}
$this->smartReadFile($filepath, $ext);

6
airtime_mvc/application/controllers/PlaylistController.php
View file

@ -198,8 +198,7 @@ class PlaylistController extends Zend_Controller_Action
public function audioPreviewPlayerAction()
{
$name = $this->_getParam('name');
$fileName = $this->_getParam('filename');
$fileID = $this->_getParam('fileID');
$playlistIndex = $this->_getParam('index');
$request = $this->getRequest();
@ -218,8 +217,7 @@ class PlaylistController extends Zend_Controller_Action
$this->view->logo = "$baseUrl/css/images/airtime_logo_jp.png";
}
$this->view->name = $name;
$this->view->fileName = $fileName;
$this->view->fileName = $fileID;
$this->view->playlistIndex= $playlistIndex;
}

2
airtime_mvc/application/models/StoredFile.php
View file

@ -660,7 +660,7 @@ Logging::log("getting media! - 2");
if($type == "au"){//&& isset( $audioResults )) {
$row['audioFile'] = $row['gunid'].".".pathinfo($row['filepath'], PATHINFO_EXTENSION);
$row['image'] = '<div class="big_play"><span class="ui-icon ui-icon-play"></span></div>';
$row['image'] = '<div class="big_play"><img src="/css/images/icon_audioclip.png"></div>';
}
else {
$row['image'] = '<img src="/css/images/icon_playlist.png">';

3
airtime_mvc/application/views/scripts/playlist/audio-preview-player.phtml
View file

@ -1,6 +1,5 @@
<div id="content" class="jp-container">
<span class='name'><?php echo "$this->name" ?></span>
<span class='filename'><?php echo "$this->fileName" ?></span>
<span class='fileID'><?php echo "$this->fileName" ?></span>
<div id="jquery_jplayer_1" class="jp-jplayer"></div>
<div id="jp_container_1" class="jp-audio">
<div class="jp-type-single">