From 9bc1c66fe3b1af263fcac152de85c2dd6876e0f3 Mon Sep 17 00:00:00 2001 From: James Date: Thu, 5 Jul 2012 15:27:49 -0400 Subject: [PATCH 01/12] CC-2747: If the file contains '\' in its meta title, airtime doesn't detect duplicate - fixed - extra fix: there was also problem with web UI upload and it's fixed see the comment on the ticket for more detail. --- .../application/controllers/ApiController.php | 13 +++++++------ .../application/controllers/PluploadController.php | 2 +- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/airtime_mvc/application/controllers/ApiController.php b/airtime_mvc/application/controllers/ApiController.php index 8d9d1d8f4..a46367c9d 100644 --- a/airtime_mvc/application/controllers/ApiController.php +++ b/airtime_mvc/application/controllers/ApiController.php @@ -573,8 +573,9 @@ class ApiController extends Zend_Controller_Action Application_Model_Preference::SetImportTimestamp(); if ($mode == "create") { $filepath = $md['MDATA_KEY_FILEPATH']; - $filepath = str_replace("\\", "", $filepath); - $filepath = str_replace("//", "/", $filepath); + //$filepath = str_replace("\\", "", $filepath); + //$filepath = str_replace("//", "/", $filepath); + $filepath = Application_Common_OsPath::normpath($filepath); $file = Application_Model_StoredFile::RecallByFilepath($filepath); if (is_null($file)) { @@ -595,7 +596,7 @@ class ApiController extends Zend_Controller_Action } else if ($mode == "modify") { $filepath = $md['MDATA_KEY_FILEPATH']; - $filepath = str_replace("\\", "", $filepath); + //$filepath = str_replace("\\", "", $filepath); $file = Application_Model_StoredFile::RecallByFilepath($filepath); //File is not in database anymore. @@ -618,13 +619,13 @@ class ApiController extends Zend_Controller_Action } else { $filepath = $md['MDATA_KEY_FILEPATH']; - $filepath = str_replace("\\", "", $filepath); + //$filepath = str_replace("\\", "", $filepath); $file->setFilePath($filepath); } } else if ($mode == "delete") { $filepath = $md['MDATA_KEY_FILEPATH']; - $filepath = str_replace("\\", "", $filepath); + //$filepath = str_replace("\\", "", $filepath); $file = Application_Model_StoredFile::RecallByFilepath($filepath); if (is_null($file)) { @@ -637,7 +638,7 @@ class ApiController extends Zend_Controller_Action } else if ($mode == "delete_dir") { $filepath = $md['MDATA_KEY_FILEPATH']; - $filepath = str_replace("\\", "", $filepath); + //$filepath = str_replace("\\", "", $filepath); $files = Application_Model_StoredFile::RecallByPartialFilepath($filepath); foreach($files as $file){ diff --git a/airtime_mvc/application/controllers/PluploadController.php b/airtime_mvc/application/controllers/PluploadController.php index 909351d3c..6e34f10a6 100644 --- a/airtime_mvc/application/controllers/PluploadController.php +++ b/airtime_mvc/application/controllers/PluploadController.php @@ -40,7 +40,7 @@ class PluploadController extends Zend_Controller_Action $tempname = $this->_getParam('tempname'); $result = Application_Model_StoredFile::copyFileToStor($upload_dir, $filename, $tempname); if (!is_null($result)) - die('{"jsonrpc" : "2.0", "error" : {"code": '.$result['code'].', "message" : "'.$result['message'].'"}}'); + die('{"jsonrpc" : "2.0", "error" : '.json_encode($result).'}'); die('{"jsonrpc" : "2.0"}'); } From 5f1b2d23bf131e0d25c92f9fca021a2d9a10f1dc Mon Sep 17 00:00:00 2001 From: Rudi Grinberg Date: Thu, 5 Jul 2012 12:35:40 -0400 Subject: [PATCH 02/12] fixed code duplication and replaced manual path concatenation with os.path.join --- .../airtimefilemonitor/airtimenotifier.py | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/python_apps/media-monitor/airtimefilemonitor/airtimenotifier.py b/python_apps/media-monitor/airtimefilemonitor/airtimenotifier.py index 274dc26d0..312bad10d 100644 --- a/python_apps/media-monitor/airtimefilemonitor/airtimenotifier.py +++ b/python_apps/media-monitor/airtimefilemonitor/airtimenotifier.py @@ -101,16 +101,12 @@ class AirtimeNotifier(Notifier): self.bootstrap.sync_database_to_filesystem(new_storage_directory_id, new_storage_directory) self.config.storage_directory = os.path.normpath(new_storage_directory) - self.config.imported_directory = os.path.normpath(new_storage_directory + '/imported') - self.config.organize_directory = os.path.normpath(new_storage_directory + '/organize') + self.config.imported_directory = os.path.normpath(os.path.join(new_storage_directory, '/imported')) + self.config.organize_directory = os.path.normpath(os.path.join(new_storage_directory, '/organize')) - self.mmc.ensure_is_dir(self.config.storage_directory) - self.mmc.ensure_is_dir(self.config.imported_directory) - self.mmc.ensure_is_dir(self.config.organize_directory) - - self.mmc.is_readable(self.config.storage_directory, True) - self.mmc.is_readable(self.config.imported_directory, True) - self.mmc.is_readable(self.config.organize_directory, True) + for directory in [self.config.storage_directory, self.config.imported_directory, self.config.organize_directory]: + self.mmc.ensure_is_dir(directory) + self.mmc.is_readable(directory, True) self.watch_directory(new_storage_directory) elif m['event_type'] == "file_delete": From 2317a3eba8007bcf911953aeb4739d277b2e5d76 Mon Sep 17 00:00:00 2001 From: Rudi Grinberg Date: Thu, 5 Jul 2012 13:13:47 -0400 Subject: [PATCH 03/12] removed more code duplication --- .../airtimemediamonitorbootstrap.py | 20 ++++++++----------- 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/python_apps/media-monitor/airtimefilemonitor/airtimemediamonitorbootstrap.py b/python_apps/media-monitor/airtimefilemonitor/airtimemediamonitorbootstrap.py index 998446596..4f8a7c146 100644 --- a/python_apps/media-monitor/airtimefilemonitor/airtimemediamonitorbootstrap.py +++ b/python_apps/media-monitor/airtimefilemonitor/airtimemediamonitorbootstrap.py @@ -156,16 +156,12 @@ class AirtimeMediaMonitorBootstrap(): self.logger.debug(full_file_path) self.pe.handle_removed_file(False, full_file_path) - for file_path in new_files_set: - self.logger.debug("new file") - full_file_path = os.path.join(dir, file_path) - self.logger.debug(full_file_path) - if os.path.exists(full_file_path): - self.pe.handle_created_file(False, full_file_path, os.path.basename(full_file_path)) - for file_path in modified_files_set: - self.logger.debug("modified file") - full_file_path = "%s%s" % (dir, file_path) - self.logger.debug(full_file_path) - if os.path.exists(full_file_path): - self.pe.handle_modified_file(False, full_file_path, os.path.basename(full_file_path)) + for file_set, debug_message, handle_attribute in [(new_files_set, "new file", "handle_created_file"), + (modified_files_set, "modified file", "handle_modified_file")]: + for file_path in file_set: + self.logger.debug(debug_message) + full_file_path = os.path.join(dir, file_path) + self.logger.debug(full_file_path) + is os.path.exists(full_file_path): + getattr(self.pe,handle_attribute)(False,full_file_path, os.path.basename(full_file_path)) From 3dfb35d2d19e43ff148a837e19fd85a266857eaf Mon Sep 17 00:00:00 2001 From: Rudi Grinberg Date: Thu, 5 Jul 2012 14:06:26 -0400 Subject: [PATCH 04/12] Fixed typo. Made supported_file_formats static because they should be same for all instances --- .../airtimefilemonitor/airtimemediamonitorbootstrap.py | 2 +- .../media-monitor/airtimefilemonitor/mediamonitorcommon.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/python_apps/media-monitor/airtimefilemonitor/airtimemediamonitorbootstrap.py b/python_apps/media-monitor/airtimefilemonitor/airtimemediamonitorbootstrap.py index 4f8a7c146..fd34811ad 100644 --- a/python_apps/media-monitor/airtimefilemonitor/airtimemediamonitorbootstrap.py +++ b/python_apps/media-monitor/airtimefilemonitor/airtimemediamonitorbootstrap.py @@ -163,5 +163,5 @@ class AirtimeMediaMonitorBootstrap(): self.logger.debug(debug_message) full_file_path = os.path.join(dir, file_path) self.logger.debug(full_file_path) - is os.path.exists(full_file_path): + if os.path.exists(full_file_path): getattr(self.pe,handle_attribute)(False,full_file_path, os.path.basename(full_file_path)) diff --git a/python_apps/media-monitor/airtimefilemonitor/mediamonitorcommon.py b/python_apps/media-monitor/airtimefilemonitor/mediamonitorcommon.py index 0c2f5b68a..79e2fa9cd 100644 --- a/python_apps/media-monitor/airtimefilemonitor/mediamonitorcommon.py +++ b/python_apps/media-monitor/airtimefilemonitor/mediamonitorcommon.py @@ -16,9 +16,9 @@ import pyinotify class MediaMonitorCommon: timestamp_file = "/var/tmp/airtime/media-monitor/last_index" + supported_file_formats = ['mp3', 'ogg'] def __init__(self, airtime_config, wm=None): - self.supported_file_formats = ['mp3', 'ogg'] self.logger = logging.getLogger() self.config = airtime_config self.md_manager = AirtimeMetadata() From 6c1af8a96e6ed4a4a0fb8f08f4fef9970b83f4c5 Mon Sep 17 00:00:00 2001 From: Rudi Grinberg Date: Thu, 5 Jul 2012 14:41:33 -0400 Subject: [PATCH 05/12] Changed uses of 'find' to respect supported_file_formats list --- .../airtimefilemonitor/airtimemediamonitorbootstrap.py | 4 ++-- .../airtimefilemonitor/mediamonitorcommon.py | 10 +++++++++- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/python_apps/media-monitor/airtimefilemonitor/airtimemediamonitorbootstrap.py b/python_apps/media-monitor/airtimefilemonitor/airtimemediamonitorbootstrap.py index fd34811ad..15aff6745 100644 --- a/python_apps/media-monitor/airtimefilemonitor/airtimemediamonitorbootstrap.py +++ b/python_apps/media-monitor/airtimefilemonitor/airtimemediamonitorbootstrap.py @@ -109,9 +109,9 @@ class AirtimeMediaMonitorBootstrap(): if os.path.exists(self.mmc.timestamp_file): """find files that have been modified since the last time media-monitor process started.""" time_diff_sec = time.time() - os.path.getmtime(self.mmc.timestamp_file) - command = "find '%s' -iname '*.ogg' -o -iname '*.mp3' -type f -readable -mmin -%d" % (dir, time_diff_sec/60+1) + command = self.mmc.find_command(directory=dir, extra_arguments=("-type f -readable -mmin -%d" % (time_diff_sec/60+1))) else: - command = "find '%s' -iname '*.ogg' -o -iname '*.mp3' -type f -readable" % dir + command = self.mmc.find_command(directory=dir, extra_arguments="-type f -readable -mmin -%d") self.logger.debug(command) stdout = self.mmc.exec_command(command) diff --git a/python_apps/media-monitor/airtimefilemonitor/mediamonitorcommon.py b/python_apps/media-monitor/airtimefilemonitor/mediamonitorcommon.py index 79e2fa9cd..b35dbe7a7 100644 --- a/python_apps/media-monitor/airtimefilemonitor/mediamonitorcommon.py +++ b/python_apps/media-monitor/airtimefilemonitor/mediamonitorcommon.py @@ -24,6 +24,14 @@ class MediaMonitorCommon: self.md_manager = AirtimeMetadata() self.wm = wm + + def find_command(self, directory, extra_arguments=""): + """ Builds a find command that respects supported_file_formats list + Note: Use single quotes to quote arguments """ + ext_globs = [ "-iname '*.%s'" % ext for ext in self.supported_file_formats ] + find_glob = ' -o '.join(ext_globs) + return "find '%s' %s %s" % (directory, find_glob, extra_arguments) + def is_parent_directory(self, filepath, directory): filepath = os.path.normpath(filepath) directory = os.path.normpath(directory) @@ -280,7 +288,7 @@ class MediaMonitorCommon: return stdout def scan_dir_for_new_files(self, dir): - command = 'find "%s" -iname "*.ogg" -o -iname "*.mp3" -type f -readable' % dir.replace('"', '\\"') + command = self.find_command(directory=dir, extra_arguments="-type f -readable") self.logger.debug(command) stdout = self.exec_command(command) From 1916ea8b0e4faecbd78d5b79822e8fa3dd8331a3 Mon Sep 17 00:00:00 2001 From: Rudi Grinberg Date: Thu, 5 Jul 2012 15:06:45 -0400 Subject: [PATCH 06/12] Put duplicate code into mediamonitorcommon. Removed unnecessary blank lines --- .../airtimemediamonitorbootstrap.py | 16 ++++++---------- .../airtimefilemonitor/mediamonitorcommon.py | 4 ++++ 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/python_apps/media-monitor/airtimefilemonitor/airtimemediamonitorbootstrap.py b/python_apps/media-monitor/airtimefilemonitor/airtimemediamonitorbootstrap.py index 15aff6745..d7d9e82ea 100644 --- a/python_apps/media-monitor/airtimefilemonitor/airtimemediamonitorbootstrap.py +++ b/python_apps/media-monitor/airtimefilemonitor/airtimemediamonitorbootstrap.py @@ -77,10 +77,8 @@ class AirtimeMediaMonitorBootstrap(): dir -- pathname of the directory """ def sync_database_to_filesystem(self, dir_id, dir): - + # TODO: is this line even necessary? dir = os.path.normpath(dir)+"/" - - """ set to hold new and/or modified files. We use a set to make it ok if files are added twice. This is because some of the tests for new files return result sets that are not @@ -94,17 +92,16 @@ class AirtimeMediaMonitorBootstrap(): for file in files['files']: db_known_files_set.add(file) - all_files = self.mmc.scan_dir_for_new_files(dir) + all_files = self.mmc.clean_dirty_file_paths( self.mmc.scan_dir_for_new_files(dir) ) all_files_set = set() for file_path in all_files: - file_path = file_path.strip(" \n") - if len(file_path) > 0 and self.config.problem_directory not in file_path: + if self.config.problem_directory not in file_path: all_files_set.add(file_path[len(dir):]) # if dir doesn't exists, update db if not os.path.exists(dir): - self.pe.handle_watched_dir_missing(dir) + self.pe.handle_stdout_files(dir) if os.path.exists(self.mmc.timestamp_file): """find files that have been modified since the last time media-monitor process started.""" @@ -120,12 +117,11 @@ class AirtimeMediaMonitorBootstrap(): self.logger.error("Unrecoverable error when syncing db to filesystem.") return - new_files = stdout.splitlines() + new_files = self.mmc.clean_dirty_file_paths(stdout.splitlines()) new_and_modified_files = set() for file_path in new_files: - file_path = file_path.strip(" \n") - if len(file_path) > 0 and self.config.problem_directory not in file_path: + if self.config.problem_directory not in file_path: new_and_modified_files.add(file_path[len(dir):]) """ diff --git a/python_apps/media-monitor/airtimefilemonitor/mediamonitorcommon.py b/python_apps/media-monitor/airtimefilemonitor/mediamonitorcommon.py index b35dbe7a7..c4678deb6 100644 --- a/python_apps/media-monitor/airtimefilemonitor/mediamonitorcommon.py +++ b/python_apps/media-monitor/airtimefilemonitor/mediamonitorcommon.py @@ -25,6 +25,10 @@ class MediaMonitorCommon: self.wm = wm + def clean_dirty_file_paths(self, dirty_files): + """ clean dirty file paths by removing blanks and removing trailing/leading whitespace""" + return filter(lambda e: len(e) > 0, [ f.strip(" \n") for f in dirty_files ]) + def find_command(self, directory, extra_arguments=""): """ Builds a find command that respects supported_file_formats list Note: Use single quotes to quote arguments """ From 7f4e6f98f5e8c4bc417a26aa89eedc0d1b21cfe2 Mon Sep 17 00:00:00 2001 From: Rudi Grinberg Date: Thu, 5 Jul 2012 15:34:53 -0400 Subject: [PATCH 07/12] fixed is_audio_file to handle extensionless files. made sure is_user_readable closes opened filehandle --- .../airtimefilemonitor/mediamonitorcommon.py | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/python_apps/media-monitor/airtimefilemonitor/mediamonitorcommon.py b/python_apps/media-monitor/airtimefilemonitor/mediamonitorcommon.py index c4678deb6..653b8cf29 100644 --- a/python_apps/media-monitor/airtimefilemonitor/mediamonitorcommon.py +++ b/python_apps/media-monitor/airtimefilemonitor/mediamonitorcommon.py @@ -43,7 +43,6 @@ class MediaMonitorCommon: def is_temp_file(self, filename): info = filename.split(".") - # if file doesn't have any extension, info[-2] throws exception # Hence, checking length of info before we do anything if(len(info) >= 2): @@ -53,20 +52,19 @@ class MediaMonitorCommon: def is_audio_file(self, filename): info = filename.split(".") + if len(info) < 2: return false # handle cases like filename="mp3" return info[-1].lower() in self.supported_file_formats #check if file is readable by "nobody" def is_user_readable(self, filepath, euid='nobody', egid='nogroup'): - + f = None try: uid = pwd.getpwnam(euid)[2] gid = grp.getgrnam(egid)[2] - #drop root permissions and become "nobody" os.setegid(gid) os.seteuid(uid) - - open(filepath) + f = open(filepath) readable = True except IOError: self.logger.warn("File does not have correct permissions: '%s'", filepath) @@ -77,9 +75,9 @@ class MediaMonitorCommon: self.logger.error("traceback: %s", traceback.format_exc()) finally: #reset effective user to root + if f: f.close() os.seteuid(0) os.setegid(0) - return readable # the function only changes the permission if its not readable by www-data From 5e9302d912c9d86fc28f6ce53138cd6cf62fbf0f Mon Sep 17 00:00:00 2001 From: Rudi Grinberg Date: Thu, 5 Jul 2012 15:36:07 -0400 Subject: [PATCH 08/12] Removed unnecessary whitespace --- .../media-monitor/airtimefilemonitor/mediamonitorcommon.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/python_apps/media-monitor/airtimefilemonitor/mediamonitorcommon.py b/python_apps/media-monitor/airtimefilemonitor/mediamonitorcommon.py index 653b8cf29..ab8d10944 100644 --- a/python_apps/media-monitor/airtimefilemonitor/mediamonitorcommon.py +++ b/python_apps/media-monitor/airtimefilemonitor/mediamonitorcommon.py @@ -326,13 +326,10 @@ class MediaMonitorCommon: if return_code != 0: #print pathname for py-interpreter.log print pathname - return (return_code == 0) def move_to_problem_dir(self, source): - dest = os.path.join(self.config.problem_directory, os.path.basename(source)) - try: omask = os.umask(0) os.rename(source, dest) From 38dbc28e1cc3df553fd5b71c5e43a531c428dfe6 Mon Sep 17 00:00:00 2001 From: Rudi Grinberg Date: Thu, 5 Jul 2012 16:07:25 -0400 Subject: [PATCH 09/12] get rid of pypo permissions since it now runs as root --- .../media-monitor/airtimefilemonitor/mediamonitorcommon.py | 3 +-- python_apps/media-monitor/install/media-monitor-copy-files.py | 4 ---- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/python_apps/media-monitor/airtimefilemonitor/mediamonitorcommon.py b/python_apps/media-monitor/airtimefilemonitor/mediamonitorcommon.py index ab8d10944..5a5ea82e2 100644 --- a/python_apps/media-monitor/airtimefilemonitor/mediamonitorcommon.py +++ b/python_apps/media-monitor/airtimefilemonitor/mediamonitorcommon.py @@ -83,8 +83,7 @@ class MediaMonitorCommon: # the function only changes the permission if its not readable by www-data def is_readable(self, item, is_dir): try: - return self.is_user_readable(item, 'www-data', 'www-data') \ - and self.is_user_readable(item, 'pypo', 'pypo') + return self.is_user_readable(item, 'www-data', 'www-data') except Exception, e: self.logger.warn(u"Failed to check owner/group/permissions for %s", item) return False diff --git a/python_apps/media-monitor/install/media-monitor-copy-files.py b/python_apps/media-monitor/install/media-monitor-copy-files.py index 736456db9..d47cd1811 100644 --- a/python_apps/media-monitor/install/media-monitor-copy-files.py +++ b/python_apps/media-monitor/install/media-monitor-copy-files.py @@ -54,14 +54,10 @@ try: #create log dir create_dir(config['log_dir']) - os.system("chown -R pypo:pypo "+config["log_dir"]) #copy python files copy_dir("%s/.."%current_script_dir, config["bin_dir"]) - #set executable permissions on python files - os.system("chown -R pypo:pypo "+config["bin_dir"]) - #copy init.d script shutil.copy(config["bin_dir"]+"/airtime-media-monitor-init-d", "/etc/init.d/airtime-media-monitor") From e67be25b85b92cbeaf9aadca50d0dd55f6d32b88 Mon Sep 17 00:00:00 2001 From: Rudi Grinberg Date: Thu, 5 Jul 2012 16:28:49 -0400 Subject: [PATCH 10/12] Fixed typo from copy pasting --- .../airtimefilemonitor/airtimemediamonitorbootstrap.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python_apps/media-monitor/airtimefilemonitor/airtimemediamonitorbootstrap.py b/python_apps/media-monitor/airtimefilemonitor/airtimemediamonitorbootstrap.py index d7d9e82ea..9d1526d8b 100644 --- a/python_apps/media-monitor/airtimefilemonitor/airtimemediamonitorbootstrap.py +++ b/python_apps/media-monitor/airtimefilemonitor/airtimemediamonitorbootstrap.py @@ -108,7 +108,7 @@ class AirtimeMediaMonitorBootstrap(): time_diff_sec = time.time() - os.path.getmtime(self.mmc.timestamp_file) command = self.mmc.find_command(directory=dir, extra_arguments=("-type f -readable -mmin -%d" % (time_diff_sec/60+1))) else: - command = self.mmc.find_command(directory=dir, extra_arguments="-type f -readable -mmin -%d") + command = self.mmc.find_command(directory=dir, extra_arguments="-type f -readable") self.logger.debug(command) stdout = self.mmc.exec_command(command) From 6fe48547d939099874be8f1249d6539b27b6547a Mon Sep 17 00:00:00 2001 From: Rudi Grinberg Date: Thu, 5 Jul 2012 16:46:25 -0400 Subject: [PATCH 11/12] Make sure md['MDATA_KEY_FILEPATH'] is always normalized --- python_apps/media-monitor/airtimefilemonitor/airtimenotifier.py | 2 +- .../media-monitor/airtimefilemonitor/mediamonitorcommon.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/python_apps/media-monitor/airtimefilemonitor/airtimenotifier.py b/python_apps/media-monitor/airtimefilemonitor/airtimenotifier.py index 312bad10d..6e0f6f69d 100644 --- a/python_apps/media-monitor/airtimefilemonitor/airtimenotifier.py +++ b/python_apps/media-monitor/airtimefilemonitor/airtimenotifier.py @@ -142,7 +142,7 @@ class AirtimeNotifier(Notifier): mode = event['mode'] md = {} - md['MDATA_KEY_FILEPATH'] = filepath + md['MDATA_KEY_FILEPATH'] = os.path.normpath(filepath) if 'data' in event: file_md = event['data'] diff --git a/python_apps/media-monitor/airtimefilemonitor/mediamonitorcommon.py b/python_apps/media-monitor/airtimefilemonitor/mediamonitorcommon.py index 5a5ea82e2..c81bbaf2a 100644 --- a/python_apps/media-monitor/airtimefilemonitor/mediamonitorcommon.py +++ b/python_apps/media-monitor/airtimefilemonitor/mediamonitorcommon.py @@ -251,7 +251,7 @@ class MediaMonitorCommon: show_name = '-'.join(title[3:]) new_md = {} - new_md["MDATA_KEY_FILEPATH"] = original_path + new_md['MDATA_KEY_FILEPATH'] = os.path.normpath(original_path) new_md['MDATA_KEY_TITLE'] = '%s-%s-%s:%s:%s' % (show_name, orig_md['MDATA_KEY_YEAR'], show_hour, show_min, show_sec) self.md_manager.save_md_to_file(new_md) From f3fbaf89f55ca7e330837d2d194df60f7a41651c Mon Sep 17 00:00:00 2001 From: James Date: Thu, 5 Jul 2012 18:23:34 -0400 Subject: [PATCH 12/12] CC-4076: Library: make doubleclick trigger adding files to playlist/timeline - done --- .../library/events/library_playlistbuilder.js | 12 ++++++++ .../library/events/library_showbuilder.js | 29 +++++++++++++++++++ .../public/js/airtime/library/library.js | 27 +++++++++++++++-- 3 files changed, 65 insertions(+), 3 deletions(-) diff --git a/airtime_mvc/public/js/airtime/library/events/library_playlistbuilder.js b/airtime_mvc/public/js/airtime/library/events/library_playlistbuilder.js index 249af5d55..4f93a02b0 100644 --- a/airtime_mvc/public/js/airtime/library/events/library_playlistbuilder.js +++ b/airtime_mvc/public/js/airtime/library/events/library_playlistbuilder.js @@ -88,6 +88,18 @@ var AIRTIME = (function(AIRTIME){ }); }; + mod.dblClickAdd = function(id, type) { + var i, + aMediaIds = []; + + //process selected files/playlists. + if (type === "audioclip") { + aMediaIds.push(id); + } + + AIRTIME.playlist.fnAddItems(aMediaIds, undefined, 'after'); + }; + mod.setupLibraryToolbar = function() { var $toolbar = $(".lib-content .fg-toolbar:first"); diff --git a/airtime_mvc/public/js/airtime/library/events/library_showbuilder.js b/airtime_mvc/public/js/airtime/library/events/library_showbuilder.js index 7d841c56d..15ec22f66 100644 --- a/airtime_mvc/public/js/airtime/library/events/library_showbuilder.js +++ b/airtime_mvc/public/js/airtime/library/events/library_showbuilder.js @@ -87,6 +87,35 @@ var AIRTIME = (function(AIRTIME){ }); }; + mod.dblClickAdd = function(id, type) { + + var i, + length, + temp, + aMediaIds = [], + aSchedIds = [], + aData = []; + + //process selected files/playlists. + aMediaIds.push({"id": id, "type": type}); + + $("#show_builder_table tr.cursor-selected-row").each(function(i, el){ + aData.push($(el).prev().data("aData")); + }); + + //process selected schedule rows to add media after. + for (i=0, length = aData.length; i < length; i++) { + temp = aData[i]; + aSchedIds.push({"id": temp.id, "instance": temp.instance, "timestamp": temp.timestamp}); + } + + if(aSchedIds.length == 0){ + alert("Please select a cursor position on timeline."); + return false; + } + AIRTIME.showbuilder.fnAdd(aMediaIds, aSchedIds); + }; + mod.setupLibraryToolbar = function() { var $toolbar = $(".lib-content .fg-toolbar:first"); diff --git a/airtime_mvc/public/js/airtime/library/library.js b/airtime_mvc/public/js/airtime/library/library.js index 2f6910978..3f623484b 100644 --- a/airtime_mvc/public/js/airtime/library/library.js +++ b/airtime_mvc/public/js/airtime/library/library.js @@ -428,11 +428,32 @@ var AIRTIME = (function(AIRTIME) { return false; }); + alreadyclicked=false; //call the context menu so we can prevent the event from propagating. $(nRow).find('td:not(.library_checkbox, .library_type)').click(function(e){ - - $(this).contextMenu({x: e.pageX, y: e.pageY}); - + var el=$(this); + if (alreadyclicked) + { + alreadyclicked=false; // reset + clearTimeout(alreadyclickedTimeout); // prevent this from happening + // do what needs to happen on double click. + + $tr = $(el).parent(); + data = $tr.data("aData"); + AIRTIME.library.dblClickAdd(data.id, data.ftype); + //AIRTIME.playlist.fnAddItems([data.id], undefined, 'after'); + } + else + { + alreadyclicked=true; + alreadyclickedTimeout=setTimeout(function(){ + alreadyclicked=false; // reset when it happens + // do what needs to happen on single click. + // use el instead of $(this) because $(this) is + // no longer the element + el.contextMenu({x: e.pageX, y: e.pageY}); + },300); // <-- dblclick tolerance here + } return false; });