Congegni
/
sintonia
7
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cc-3936: Clarified comments regarding event hooks and file ownership.

This commit is contained in:
Rudi Grinberg 2012-08-27 12:07:54 -04:00
parent 687a6d3c5a
commit 7270893b4d
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
python_apps/media-monitor2/media/monitor/events.py
View File

@ -98,11 +98,11 @@ class BaseEvent(Loggable):
events that must catch their own BadSongFile exceptions since generate events that must catch their own BadSongFile exceptions since generate
a set of exceptions instead of a single one a set of exceptions instead of a single one
""" """
# pack will only throw an exception if it processes one file but this
# is a little bit hacky
try: try:
self._pack_hook() self._pack_hook()
ret = self.pack() ret = self.pack()
# Remove owner of this file only after packing. Otherwise packing
# will not serialize the owner correctly into the airtime request
owners.remove_file_owner(self.path) owners.remove_file_owner(self.path)
return ret return ret
except BadSongFile as e: return [e] except BadSongFile as e: return [e]
@ -114,6 +114,8 @@ class BaseEvent(Loggable):
self.path = evt.path self.path = evt.path
self.__class__ = evt.__class__ self.__class__ = evt.__class__
# We don't transfer the _pack_hook over to the new event # We don't transfer the _pack_hook over to the new event
# TODO : perhaps we should call the old events pack_hook just to make
# sure everything is done cleanly?
return self return self
def assign_owner(self,req): def assign_owner(self,req):