fixed ticket #1668:

added a missing reset() method to the authentication client;
now using this reset() method in the unit test to avoid dependence on earlier events

livesupport/src/modules/authentication/include/LiveSupport/Authentication/AuthenticationClientInterface.h

@@ -203,6 +203,18 @@ class AuthenticationClientInterface
                                                 throw (XmlRpcException)
                                                                         = 0;
 
+        /**
+         *  Reset the authentication client.
+         *  Invalidates all active session IDs, and resets the list of 
+         *  preferences to its initial (empty) state.
+         *
+         *  @exception XmlRpcException if the server returns an error.
+         */
+        virtual void
+        reset(void)
+                                                throw (XmlRpcException)
+                                                                        = 0;
+
         /**
          *  A virtual destructor, as this class has virtual functions.
          */

livesupport/src/modules/authentication/src/AuthenticationClientFactoryTest.cxx

@@ -114,6 +114,10 @@ AuthenticationClientFactoryTest :: firstTest(void)
     Ptr<AuthenticationClientInterface>::Ref
                             authentication = acf->getAuthenticationClient();
     
+    CPPUNIT_ASSERT_NO_THROW(
+        authentication->reset()
+    );
+
     Ptr<SessionId>::Ref     sessionId;
     
     try {
@@ -144,6 +148,10 @@ AuthenticationClientFactoryTest :: preferencesTest(void)
     Ptr<AuthenticationClientInterface>::Ref
                             authentication = acf->getAuthenticationClient();
     
+    CPPUNIT_ASSERT_NO_THROW(
+        authentication->reset()
+    );
+
     Ptr<SessionId>::Ref             sessionId;
     Ptr<const Glib::ustring>::Ref   prefValue;
 

livesupport/src/modules/authentication/src/TestAuthenticationClient.cxx

@@ -280,3 +280,17 @@ TestAuthenticationClient :: deletePreferencesItem(
     preferences.erase(it);
 }
 
+
+/*------------------------------------------------------------------------------
+ *  Reset the list of preferences to its initial (empty) state.
+ *----------------------------------------------------------------------------*/
+void
+TestAuthenticationClient :: reset(void)
+                                                throw (XmlRpcException)
+{
+    sessionIdList.clear();
+    sessionCounter = 0;
+    
+    preferences.clear();
+}
+

livesupport/src/modules/authentication/src/TestAuthenticationClient.h

@@ -261,6 +261,17 @@ class TestAuthenticationClient :
         deletePreferencesItem(Ptr<SessionId>::Ref           sessionId,
                               const Glib::ustring &         key)
                                                 throw (XmlRpcException);
+
+        /**
+         *  Reset the authentication client.
+         *  Invalidates all active session IDs, and resets the list of 
+         *  preferences to its initial (empty) state.
+         *
+         *  @exception XmlRpcException if the server returns an error.
+         */
+        virtual void
+        reset(void)
+                                                throw (XmlRpcException);
 };
 
 

livesupport/src/modules/authentication/src/WebAuthenticationClient.h

@@ -272,11 +272,13 @@ class WebAuthenticationClient :
                                                 throw (XmlRpcException);
 
         /**
-         *  Reset the list of preferences to its initial (empty) state.
+         *  Reset the authentication client.
+         *  Invalidates all active session IDs, and resets the list of 
+         *  preferences to its initial (empty) state.
          *
          *  @exception XmlRpcException if the server returns an error.
          */
-        void
+        virtual void
         reset(void)
                                                 throw (XmlRpcException);
 };