Congegni
/
sintonia
7
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(shared): set logger encoding and dont assume encoding 

Older versions of python might have ascii as default, we
should not assume that the default encoding always is "utf-8"
when opening files.
This commit is contained in:
jo 2022-01-31 13:29:14 +01:00 committed by Kyle Robbertze
parent f6fe318278
commit 80dfbd3179
3 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
shared/libretime_shared/logging.py
View File

@ -75,6 +75,7 @@ def setup_logger(
"serialize": serialize, "serialize": serialize,
"rotation": "12:00", "rotation": "12:00",
"retention": "7 days", "retention": "7 days",
"encoding": "utf-8",
} }
) )
@ -108,6 +109,7 @@ def create_task_logger(
"serialize": serialize, "serialize": serialize,
"rotation": "12:00", "rotation": "12:00",
"retention": "7 days", "retention": "7 days",
"encoding": "utf-8",
} }
], ],
) )

1
shared/setup.py
View File

@ -18,7 +18,6 @@ setup(
package_data={"": ["py.typed"]}, package_data={"": ["py.typed"]},
install_requires=[ install_requires=[
"click>=8.0.3", "click>=8.0.3",
# Pinned until https://github.com/Delgan/loguru/issues/581 is fixed
"loguru==0.6.0", "loguru==0.6.0",
"pydantic", "pydantic",
"pyyaml", "pyyaml",

4
shared/tests/logging_test.py
View File

@ -48,5 +48,5 @@ def test_setup_logger(tmp_path: Path):
extra_logger.complete() extra_logger.complete()
logger.complete() logger.complete()
assert len(log_filepath.read_text().splitlines()) == 1 assert len(log_filepath.read_text(encoding="utf-8").splitlines()) == 1
assert len(extra_log_filepath.read_text().splitlines()) == 1 assert len(extra_log_filepath.read_text(encoding="utf-8").splitlines()) == 1