From b0f2176329c15955eb46609cece231f557290bf2 Mon Sep 17 00:00:00 2001 From: Martin Konecny Date: Tue, 18 Sep 2012 12:40:44 -0400 Subject: [PATCH 1/2] fix some TODO's in webstream.php --- .../application/controllers/WebstreamController.php | 11 ----------- airtime_mvc/application/models/Webstream.php | 11 +++++------ 2 files changed, 5 insertions(+), 17 deletions(-) diff --git a/airtime_mvc/application/controllers/WebstreamController.php b/airtime_mvc/application/controllers/WebstreamController.php index e9e93fe44..ebb5acbf6 100644 --- a/airtime_mvc/application/controllers/WebstreamController.php +++ b/airtime_mvc/application/controllers/WebstreamController.php @@ -35,17 +35,6 @@ class WebstreamController extends Zend_Controller_Action $webstream->setDbUtime(new DateTime("now", new DateTimeZone('UTC'))); $webstream->setDbMtime(new DateTime("now", new DateTimeZone('UTC'))); - /* - $type = "stream"; - $objInfo = Application_Model_Library::getObjInfo($type); - - $obj = new $objInfo['className']($webstream); - $obj->setName($webstream->getDbName()); - $obj->setMetadata('dc:creator', $userInfo->id); - - $type = "stream"; - Application_Model_Library::changePlaylist($obj->getId(), $type); - */ //clear the session in case an old playlist was open: CC-4196 Application_Model_Library::changePlaylist(null, null); diff --git a/airtime_mvc/application/models/Webstream.php b/airtime_mvc/application/models/Webstream.php index e3f08858a..561f97b12 100644 --- a/airtime_mvc/application/models/Webstream.php +++ b/airtime_mvc/application/models/Webstream.php @@ -39,7 +39,7 @@ class Application_Model_Webstream implements Application_Model_LibraryEditable public function getLastModified($p_type) { - return "modified"; + return $this->webstream->getDbMtime(); } public function getDefaultLength() @@ -215,15 +215,16 @@ class Application_Model_Webstream implements Application_Model_LibraryEditable return true; } - // TODO : properly implement this interface + // TODO : Fix this interface public function setMetadata($key, $val) { - throw new Exception("setMetadata is not imeplemented by WebStream yet"); + //This function should not be defined in the interface. + throw new Exception("Not implemented."); } public function setName($name) { - throw new Exception("setName is not imeplemented by WebStream yet"); + $this->webstream->setDbName($name); } public function setLastPlayed($timestamp) @@ -243,8 +244,6 @@ class Application_Model_Webstream implements Application_Model_LibraryEditable //TODO: What if invalid url? $content = curl_exec($ch); - Logging::debug($content); - // close cURL resource, and free up system resources curl_close($ch); From b1f0bdb6ae49d9b2a56294b4ce295984685a7d2c Mon Sep 17 00:00:00 2001 From: Martin Konecny Date: Tue, 18 Sep 2012 12:41:19 -0400 Subject: [PATCH 2/2] CC-4377: Make sure upgrade script handles new required packages -removing package checking from main install script (not its duty to perform this) --- install_minimal/airtime-install | 30 ------------------------------ 1 file changed, 30 deletions(-) diff --git a/install_minimal/airtime-install b/install_minimal/airtime-install index 14f713296..b0034ab59 100755 --- a/install_minimal/airtime-install +++ b/install_minimal/airtime-install @@ -82,36 +82,6 @@ SCRIPT=`readlink -f $0` SCRIPTPATH=`dirname $SCRIPT` AIRTIMEROOT=$SCRIPTPATH/../ -#Check if required zend mvc library is present. This is a temporary workaround for 2.0.1, -#and we should probably create a separate file that checks whether ALL dependencies are satisfied before -#allowing the install to continue. However in that case, we wouldn't check for Debian packages so that we -#can become less Debian platform dependent in the future... - -set +e -dpkg -l | grep zendframework > /dev/null 2>&1 -ZENDFRAMEWORK=$? - -dpkg -l | grep libzend-framework-php > /dev/null 2>&1 -LIBZEND=$? - -dpkg -l | grep lsof > /dev/null 2>&1 -LSOF_EXIST=$? - -dpkg -l | grep sudo > /dev/null 2>&1 -SUDO_EXIST=$? - -set -e - -if [ "$ZENDFRAMEWORK" != "0" -a "$LIBZEND" != "0" ]; then - echo "zendframework/libzend-framework-php package missing. Please run airtime-full-install" - exit 1 -fi - -if [ "$LSOF_EXIST" != "0" -o "$SUDO_EXIST" != "0" ]; then - echo "Packages missing. Please run airtime-full-install" - exit 1 -fi - echo "* Making sure /etc/default/locale is set properly" set +e update-locale