Congegni/sintonia
7
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

CC-2436: Save pulldown settings

Browse source 
Fixing the issue of "show entries" dropdown setting not being saved.
After some investigation, it seems like we're destroying the calendar
everytime we modify the dropdown value, and create a new one,
which explains why the new setting is not being saved.

Fixed by moving the code that handles the updating to the place after
we create the new calendar. This makes the code cleaner as well.
This commit is contained in:
Yuchen Wang 2011-11-16 15:52:05 -05:00
parent a5939afd3f
commit a0bf7c90ba
3 changed files with 28 additions and 44 deletions
Download patch file Download diff file Expand all files Collapse all files

26
airtime_mvc/application/models/Preference.php
View file

@ -559,19 +559,24 @@ class Application_Model_Preference
/* User specific preferences start */
/**
* Sets the time scale preference (day/week/month) in Calendar.
* Sets the time scale preference (agendaDay/agendaWeek/month) in Calendar.
*
* @param $timeScale new time scale
*/
public static function SetCalendarTimeScale($timeScale) {
return self::SetValue("calendar_time_scale", $timeScale, true /* user specific */);
public static function SetCalendarTimeScale($timeScale) {
self::SetValue("calendar_time_scale", $timeScale, true /* user specific */);
}
/**
* Retrieves the time scale preference for the current user.
* Defaults to month if no entry exists
*/
public static function GetCalendarTimeScale() {
return self::GetValue("calendar_time_scale", true /* user specific */);
$val = self::GetValue("calendar_time_scale", true /* user specific */);
if(strlen($val) == 0) {
$val = 'month';
}
return $val;
}
/**
@ -580,7 +585,7 @@ class Application_Model_Preference
* @param $numEntries new number of entries to show
*/
public static function SetLibraryNumEntries($numEntries) {
return self::SetValue("library_num_entries", $numEntries, true /* user specific */);
self::SetValue("library_num_entries", $numEntries, true /* user specific */);
}
/**
@ -595,15 +600,20 @@ class Application_Model_Preference
*
* @param $timeInterval new time interval
*/
public static function SetCalendarTimeInterval($timeInterval) {
return self::SetValue("calendar_time_interval", $timeInterval, true /* user specific */);
public static function SetCalendarTimeInterval($timeInterval) {
self::SetValue("calendar_time_interval", $timeInterval, true /* user specific */);
}
/**
* Retrieves the time interval preference for the current user.
* Defaults to 30 min if no entry exists
*/
public static function GetCalendarTimeInterval() {
return self::GetValue("calendar_time_interval", true /* user specific */);
$val = self::GetValue("calendar_time_interval", true /* user specific */);
if(strlen($val) == 0) {
$val = "30";
}
return $val;
}
/* User specific preferences end */