Congegni/sintonia
7
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

CC-2986: Long show description causes Add Show or Edit Show to fail silently

Browse source 
Added StringLength validators for the UI fields. This way when user gave more than what
they should gave as the input, it's going to display an error msg.

The maximum length for the fields is queried from the database before the
fields were initialized.
This commit is contained in:
Yuchen Wang 2011-10-24 13:27:53 -04:00
parent 6d15308e1d
commit a65fb97aec
2 changed files with 26 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

18
airtime_mvc/application/forms/AddShowWhat.php
View file

@ -2,9 +2,12 @@
class Application_Form_AddShowWhat extends Zend_Form_SubForm
{
public function init()
{
// retrieves the length limit for each char field
// and store to assoc array
$maxLens = Application_Model_Show::GetMaxLengths();
// Hidden element to indicate whether the show is new or
// whether we are updating an existing show.
$this->addElement('hidden', 'add_show_id', array(
@ -18,7 +21,8 @@ class Application_Form_AddShowWhat extends Zend_Form_SubForm
'required' => true,
'filters' => array('StringTrim'),
'validators' => array('NotEmpty'),
'value' => 'Untitled Show'
'value' => 'Untitled Show',
'validators' => array(array('StringLength', false, array(0, $maxLens['name'])))
));
// Add URL element
@ -27,7 +31,7 @@ class Application_Form_AddShowWhat extends Zend_Form_SubForm
'class' => 'input_text',
'required' => false,
'filters' => array('StringTrim'),
'validators' => array('NotEmpty')
'validators' => array('NotEmpty', array('StringLength', false, array(0, $maxLens['url'])))
));
// Add genre element
@ -35,14 +39,16 @@ class Application_Form_AddShowWhat extends Zend_Form_SubForm
'label' => 'Genre:',
'class' => 'input_text',
'required' => false,
'filters' => array('StringTrim')
'filters' => array('StringTrim'),
'validators' => array(array('StringLength', false, array(0, $maxLens['genre'])))
));
// Add the description element
$this->addElement('textarea', 'add_show_description', array(
'label' => 'Description:',
'required' => false,
'class' => 'input_text_area'
'class' => 'input_text_area',
'validators' => array(array('StringLength', false, array(0, $maxLens['description'])))
));
$descText = $this->getElement('add_show_description');
@ -53,7 +59,5 @@ class Application_Form_AddShowWhat extends Zend_Form_SubForm
))));
}
}