Congegni/sintonia
7
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Format code using php-cs-fixer

Browse source
This commit is contained in:
jo 2021-10-11 16:10:47 +02:00
parent 43d7dc92cd
commit d52c6184b9
352 changed files with 17473 additions and 17041 deletions
Download patch file Download diff file Expand all files Collapse all files

304
legacy/application/services/PodcastEpisodeService.php
View file

@ -1,18 +1,21 @@
<?php
class PodcastEpisodeNotFoundException extends Exception {}
class PodcastEpisodeNotFoundException extends Exception
{
}
class DuplicatePodcastEpisodeException extends Exception {}
class DuplicatePodcastEpisodeException extends Exception
{
}
class Application_Service_PodcastEpisodeService extends Application_Service_ThirdPartyCeleryService implements Publish
{
/**
* Arbitrary constant identifiers for the internal tasks array
* Arbitrary constant identifiers for the internal tasks array.
*/
public const DOWNLOAD = 'download';
const DOWNLOAD = 'download';
const PENDING_EPISODE_TIMEOUT_SECONDS = 900;
public const PENDING_EPISODE_TIMEOUT_SECONDS = 900;
/**
* @var string service name to store in ThirdPartyTrackReferences database
@ -28,90 +31,98 @@ class Application_Service_PodcastEpisodeService extends Application_Service_Thir
* @var array map of constant identifiers to Celery task names
*/
protected static $_CELERY_TASKS = [
self::DOWNLOAD => 'podcast-download'
self::DOWNLOAD => 'podcast-download',
];
private static $privateFields = array(
"id"
);
private static $privateFields = [
'id',
];
/**
* Utility function to import and download a single episode
* Utility function to import and download a single episode.
*
* @param int $podcastId ID of the podcast the episode should belong to
* @param array $episode array of episode data to store
* @param int $podcastId ID of the podcast the episode should belong to
* @param array $episode array of episode data to store
*
* @return PodcastEpisodes the stored PodcastEpisodes object
*/
public function importEpisode($podcastId, $episode) {
public function importEpisode($podcastId, $episode)
{
$e = $this->addPlaceholder($podcastId, $episode);
$p = $e->getPodcast();
$this->_download($e->getDbId(), $e->getDbDownloadUrl(), $p->getDbTitle(), $this->_getAlbumOverride($p), $episode["title"]);
$this->_download($e->getDbId(), $e->getDbDownloadUrl(), $p->getDbTitle(), $this->_getAlbumOverride($p), $episode['title']);
return $e;
}
/**
* Given an array of episodes, store them in the database as placeholder objects until
* they can be processed by Celery
* they can be processed by Celery.
*
* @param int $podcastId Podcast object identifier
* @param array $episodes array of podcast episodes
* @param int $podcastId Podcast object identifier
* @param array $episodes array of podcast episodes
*
* @return array the stored PodcastEpisodes objects
*/
public function addPodcastEpisodePlaceholders($podcastId, $episodes) {
$storedEpisodes = array();
public function addPodcastEpisodePlaceholders($podcastId, $episodes)
{
$storedEpisodes = [];
foreach ($episodes as $episode) {
try {
$e = $this->addPlaceholder($podcastId, $episode);
} catch(DuplicatePodcastEpisodeException $ex) {
} catch (DuplicatePodcastEpisodeException $ex) {
Logging::warn($ex->getMessage());
continue;
}
array_push($storedEpisodes, $e);
}
return $storedEpisodes;
}
/**
* Given an episode, store it in the database as a placeholder object until
* it can be processed by Celery
* it can be processed by Celery.
*
* @param int $podcastId Podcast object identifier
* @param array $episode array of podcast episode data
*
* @return PodcastEpisodes the stored PodcastEpisodes object
* @param int $podcastId Podcast object identifier
* @param array $episode array of podcast episode data
*
* @throws DuplicatePodcastEpisodeException
*
* @return PodcastEpisodes the stored PodcastEpisodes object
*/
public function addPlaceholder($podcastId, $episode) {
$existingEpisode = PodcastEpisodesQuery::create()->findOneByDbEpisodeGuid($episode["guid"]);
public function addPlaceholder($podcastId, $episode)
{
$existingEpisode = PodcastEpisodesQuery::create()->findOneByDbEpisodeGuid($episode['guid']);
if (!empty($existingEpisode)) {
throw new DuplicatePodcastEpisodeException(sprintf("Episode already exists for podcast: %s, guid: %s\n", $episode['podcast_id'], $episode['guid']));
}
// We need to check whether the array is parsed directly from the SimplePie
// feed object, or whether it's passed in as json
$enclosure = $episode["enclosure"];
$url = $enclosure instanceof SimplePie_Enclosure ? $enclosure->get_link() : $enclosure["link"];
return $this->_buildEpisode($podcastId, $url, $episode["guid"], $episode["pub_date"], $episode["title"], $episode["description"]);
$enclosure = $episode['enclosure'];
$url = $enclosure instanceof SimplePie_Enclosure ? $enclosure->get_link() : $enclosure['link'];
return $this->_buildEpisode($podcastId, $url, $episode['guid'], $episode['pub_date'], $episode['title'], $episode['description']);
}
/**
* Given episode parameters, construct and store a basic PodcastEpisodes object
* Given episode parameters, construct and store a basic PodcastEpisodes object.
*
* @param int $podcastId the podcast the episode belongs to
* @param string $url the download URL for the episode
* @param string $guid the unique id for the episode. Often the same as the download URL
* @param string $publicationDate the publication date of the episode
* @param string $title the title of the episode
* @param string $description the description of the epsiode
*
* @return PodcastEpisodes the newly created PodcastEpisodes object
* @param int $podcastId the podcast the episode belongs to
* @param string $url the download URL for the episode
* @param string $guid the unique id for the episode. Often the same as the download URL
* @param string $publicationDate the publication date of the episode
* @param string $title the title of the episode
* @param string $description the description of the epsiode
*
* @throws Exception
* @throws PropelException
*
* @return PodcastEpisodes the newly created PodcastEpisodes object
*/
private function _buildEpisode($podcastId, $url, $guid, $publicationDate, $title = NULL, $description = NULL) {
private function _buildEpisode($podcastId, $url, $guid, $publicationDate, $title = null, $description = null)
{
$e = new PodcastEpisodes();
$e->setDbPodcastId($podcastId);
$e->setDbDownloadUrl($url);
@ -120,60 +131,66 @@ class Application_Service_PodcastEpisodeService extends Application_Service_Thir
$e->setDbEpisodeTitle($title);
$e->setDbEpisodeDescription($description);
$e->save();
return $e;
}
/**
* Given an array of episodes, extract the IDs and download URLs and send them to Celery
* Given an array of episodes, extract the IDs and download URLs and send them to Celery.
*
* @param array $episodes array of podcast episodes
*/
public function downloadEpisodes($episodes) {
public function downloadEpisodes($episodes)
{
/** @var PodcastEpisodes $episode */
foreach($episodes as $episode) {
foreach ($episodes as $episode) {
$podcast = $episode->getPodcast();
$this->_download($episode->getDbId(), $episode->getDbDownloadUrl(), $podcast->getDbTitle(), $this->_getAlbumOverride($podcast), $episode->getDbEpisodeTitle());
}
}
/**
* check if there is a podcast specific album override
* check if there is a podcast specific album override.
*
* @param object $podcast podcast object
*
* @return boolean
* @return bool
*/
private function _getAlbumOverride($podcast) {
private function _getAlbumOverride($podcast)
{
$override = Application_Model_Preference::GetPodcastAlbumOverride();
$podcast_override = $podcast->toArray();
$podcast_override = $podcast_override['DbAlbumOverride'];
if ($podcast_override) {
$override = $podcast_override;
}
return $override;
}
/**
* Given an episode ID and a download URL, send a Celery task
* to download an RSS feed track
* to download an RSS feed track.
*
* @param int $id episode unique ID
* @param string $url download url for the episode
* @param string $title title of podcast to be downloaded - added as album to track metadata
* @param boolean $album_override should we override the album name when downloading
* @param int $id episode unique ID
* @param string $url download url for the episode
* @param string $title title of podcast to be downloaded - added as album to track metadata
* @param bool $album_override should we override the album name when downloading
* @param null|mixed $track_title
*/
private function _download($id, $url, $title, $album_override, $track_title = null) {
private function _download($id, $url, $title, $album_override, $track_title = null)
{
$CC_CONFIG = Config::getConfig();
$stationUrl = Application_Common_HTTPHelper::getStationUrl();
$stationUrl .= substr($stationUrl, -1) == '/' ? '' : '/';
$data = array(
'id' => $id,
'url' => $url,
'callback_url' => $stationUrl . 'rest/media',
'api_key' => $CC_CONFIG["apiKey"][0],
'podcast_name' => $title,
$data = [
'id' => $id,
'url' => $url,
'callback_url' => $stationUrl . 'rest/media',
'api_key' => $CC_CONFIG['apiKey'][0],
'podcast_name' => $title,
'album_override' => $album_override,
'track_title' => $track_title);
'track_title' => $track_title, ];
$task = $this->_executeTask(static::$_CELERY_TASKS[self::DOWNLOAD], $data);
// Get the created ThirdPartyTaskReference and set the episode ID so
// we can remove the placeholder if the import ends up stuck in a pending state
@ -182,19 +199,20 @@ class Application_Service_PodcastEpisodeService extends Application_Service_Thir
}
/**
* Update a ThirdPartyTrackReferences object for a completed upload
* Update a ThirdPartyTrackReferences object for a completed upload.
*
* @param $task CeleryTasks the completed CeleryTasks object
* @param $episodeId int PodcastEpisodes identifier
* @param $episode stdClass simple object containing Podcast episode information
* @param $status string Celery task status
*
* @return ThirdPartyTrackReferences the updated ThirdPartyTrackReferences object
*
* @throws Exception
* @throws PropelException
*
* @return ThirdPartyTrackReferences the updated ThirdPartyTrackReferences object
*/
public function updateTrackReference($task, $episodeId, $episode, $status) {
public function updateTrackReference($task, $episodeId, $episode, $status)
{
$ref = parent::updateTrackReference($task, $episodeId, $episode, $status);
$ref->setDbForeignId($episode->episodeid)->save();
$dbEpisode = PodcastEpisodesQuery::create()->findOneByDbId($episode->episodeid);
@ -202,7 +220,8 @@ class Application_Service_PodcastEpisodeService extends Application_Service_Thir
try {
// If the placeholder for the episode is somehow removed, return with a warning
if (!$dbEpisode) {
Logging::warn("Celery task $task episode $episode->episodeid unsuccessful: episode placeholder removed");
Logging::warn("Celery task {$task} episode {$episode->episodeid} unsuccessful: episode placeholder removed");
return $ref;
}
@ -210,12 +229,12 @@ class Application_Service_PodcastEpisodeService extends Application_Service_Thir
if ($status == CELERY_SUCCESS_STATUS && $episode->status == 1) {
$dbEpisode->setDbFileId($episode->fileid)->save();
} else {
Logging::warn("Celery task $task episode $episode->episodeid unsuccessful with message $episode->error");
Logging::warn("Celery task {$task} episode {$episode->episodeid} unsuccessful with message {$episode->error}");
$dbEpisode->delete();
}
} catch (Exception $e) {
$dbEpisode->delete();
Logging::warn("Catastrophic failure updating from task $task, recovering by deleting episode row.\n
Logging::warn("Catastrophic failure updating from task {$task}, recovering by deleting episode row.\n
This can occur if the episode's corresponding CcFile is deleted before being processed.");
}
@ -223,13 +242,14 @@ class Application_Service_PodcastEpisodeService extends Application_Service_Thir
}
/**
* Publish the file with the given file ID to the station podcast
* Publish the file with the given file ID to the station podcast.
*
* @param int $fileId ID of the file to be published
*/
public function publish($fileId) {
public function publish($fileId)
{
$id = Application_Model_Preference::getStationPodcastId();
$url = $guid = Application_Common_HTTPHelper::getStationUrl()."rest/media/$fileId/download";
$url = $guid = Application_Common_HTTPHelper::getStationUrl() . "rest/media/{$fileId}/download";
if (!PodcastEpisodesQuery::create()
->filterByDbPodcastId($id)
->findOneByDbFileId($fileId)) { // Don't allow duplicate episodes
@ -239,20 +259,22 @@ class Application_Service_PodcastEpisodeService extends Application_Service_Thir
}
/**
* Unpublish the file with the given file ID from the station podcast
* Unpublish the file with the given file ID from the station podcast.
*
* @param int $fileId ID of the file to be unpublished
*/
public function unpublish($fileId) {
public function unpublish($fileId)
{
$id = Application_Model_Preference::getStationPodcastId();
PodcastEpisodesQuery::create()
->filterByDbPodcastId($id)
->findOneByDbFileId($fileId)
->delete();
->delete()
;
}
/**
* Fetch the publication status for the file with the given ID
* Fetch the publication status for the file with the given ID.
*
* @param int $fileId the ID of the file to check
*
@ -261,45 +283,55 @@ class Application_Service_PodcastEpisodeService extends Application_Service_Thir
* -1 if the file is in a pending state,
* 2 if the source is unreachable (disconnected)
*/
public function getPublishStatus($fileId) {
public function getPublishStatus($fileId)
{
$stationPodcast = StationPodcastQuery::create()
->findOneByDbPodcastId(Application_Model_Preference::getStationPodcastId());
->findOneByDbPodcastId(Application_Model_Preference::getStationPodcastId())
;
return (int) $stationPodcast->hasEpisodeForFile($fileId);
}
/**
* Find any episode placeholders that have been stuck pending (empty file ID) for over
* PENDING_EPISODE_TIMEOUT_SECONDS
* PENDING_EPISODE_TIMEOUT_SECONDS.
*
* @see Application_Service_PodcastEpisodeService::PENDING_EPISODE_TIMEOUT_SECONDS
*
* @return array the episode imports stuck in pending
*/
public static function getStuckPendingImports() {
public static function getStuckPendingImports()
{
$timeout = gmdate(DEFAULT_TIMESTAMP_FORMAT, (microtime(true) - self::PENDING_EPISODE_TIMEOUT_SECONDS));
$episodes = PodcastEpisodesQuery::create()
->filterByDbFileId()
->find();
$stuckImports = array();
->find()
;
$stuckImports = [];
foreach ($episodes as $episode) {
$ref = ThirdPartyTrackReferencesQuery::create()
->findOneByDbForeignId(strval($episode->getDbId()));
->findOneByDbForeignId(strval($episode->getDbId()))
;
if (!empty($ref)) {
$task = CeleryTasksQuery::create()
->filterByDbDispatchTime($timeout, Criteria::LESS_EQUAL)
->findOneByDbTrackReference($ref->getDbId());
->findOneByDbTrackReference($ref->getDbId())
;
if (!empty($task)) {
array_push($stuckImports, $episode);
}
}
}
return $stuckImports;
}
/**
* @param $episodeId
* @return array
*
* @throws PodcastEpisodeNotFoundException
*
* @return array
*/
public static function getPodcastEpisodeById($episodeId)
{
@ -315,29 +347,33 @@ class Application_Service_PodcastEpisodeService extends Application_Service_Thir
* Returns an array of Podcast episodes, with the option to paginate the results.
*
* @param $podcastId
* @param int $offset
* @param int $limit
* @param int $offset
* @param int $limit
* @param string $sortColumn
* @param string $sortDir "ASC" || "DESC"
* @return array
* @param string $sortDir "ASC" || "DESC"
*
* @throws PodcastNotFoundException
*
* @return array
*/
public function getPodcastEpisodes($podcastId,
$offset=0,
$limit=10,
$sortColumn=PodcastEpisodesPeer::PUBLICATION_DATE,
$sortDir="ASC")
{
public function getPodcastEpisodes(
$podcastId,
$offset = 0,
$limit = 10,
$sortColumn = PodcastEpisodesPeer::PUBLICATION_DATE,
$sortDir = 'ASC'
) {
$podcast = PodcastQuery::create()->findPk($podcastId);
if (!$podcast) {
throw new PodcastNotFoundException();
}
$sortDir = ($sortDir === "DESC") ? $sortDir = Criteria::DESC : Criteria::ASC;
$sortDir = ($sortDir === 'DESC') ? $sortDir = Criteria::DESC : Criteria::ASC;
$isStationPodcast = $podcastId == Application_Model_Preference::getStationPodcastId();
$episodes = PodcastEpisodesQuery::create()
->filterByDbPodcastId($podcastId);
->filterByDbPodcastId($podcastId)
;
if ($isStationPodcast && $limit != 0) {
$episodes = $episodes->setLimit($limit);
}
@ -346,7 +382,8 @@ class Application_Service_PodcastEpisodeService extends Application_Service_Thir
$episodes = $episodes->joinWith('PodcastEpisodes.CcFiles', Criteria::LEFT_JOIN)
->setOffset($offset)
->orderBy($sortColumn, $sortDir)
->find();
->find()
;
return $isStationPodcast ? $this->_getStationPodcastEpisodeArray($episodes)
: $this->_getImportedPodcastEpisodeArray($podcast, $episodes);
@ -354,59 +391,63 @@ class Application_Service_PodcastEpisodeService extends Application_Service_Thir
/**
* Given an array of PodcastEpisodes objects from the Station Podcast,
* convert the episode data into array form
* convert the episode data into array form.
*
* @param array $episodes array of PodcastEpisodes to convert
*
* @return array
*/
private function _getStationPodcastEpisodeArray($episodes) {
$episodesArray = array();
private function _getStationPodcastEpisodeArray($episodes)
{
$episodesArray = [];
foreach ($episodes as $episode) {
/** @var PodcastEpisodes $episode */
$episodeArr = $episode->toArray(BasePeer::TYPE_FIELDNAME, true, [], true);
array_push($episodesArray, $episodeArr);
}
return $episodesArray;
}
/**
* Given an ImportedPodcast object and an array of stored PodcastEpisodes objects,
* fetch all episodes from the podcast RSS feed, and serialize them in a readable form
* fetch all episodes from the podcast RSS feed, and serialize them in a readable form.
*
* TODO: there's definitely a better approach than this... we should be trying to create
* PodcastEpisdoes objects instead of our own arrays
*
* @param ImportedPodcast $podcast Podcast object to fetch the episodes for
* @param array $episodes array of PodcastEpisodes objects to
*
* @return array array of episode data
* @param ImportedPodcast $podcast Podcast object to fetch the episodes for
* @param array $episodes array of PodcastEpisodes objects to
*
* @throws CcFiles/LibreTimeFileNotFoundException
*
* @return array array of episode data
*/
public function _getImportedPodcastEpisodeArray($podcast, $episodes) {
public function _getImportedPodcastEpisodeArray($podcast, $episodes)
{
$rss = Application_Service_PodcastService::getPodcastFeed($podcast->getDbUrl());
$episodeIds = array();
$episodeFiles = array();
$episodeIds = [];
$episodeFiles = [];
foreach ($episodes as $e) {
/** @var PodcastEpisodes $e */
// @var PodcastEpisodes $e
array_push($episodeIds, $e->getDbEpisodeGuid());
$episodeFiles[$e->getDbEpisodeGuid()] = $e->getDbFileId();
}
$episodesArray = array();
$episodesArray = [];
foreach ($rss->get_items() as $item) {
/** @var SimplePie_Item $item */
// If the enclosure is empty or has not URL, this isn't a podcast episode (there's no audio data)
// technically podcasts shouldn't have multiple enclosures but often CMS add non-audio files
$enclosure = $item->get_enclosure();
$url = $enclosure instanceof SimplePie_Enclosure ? $enclosure->get_link() : $enclosure["link"];
$url = $enclosure instanceof SimplePie_Enclosure ? $enclosure->get_link() : $enclosure['link'];
if (empty($url)) {
continue;
}
// next we check and see if the enclosure is not an audio file - this can happen from improperly
// formatted podcasts and we instead will search through the enclosures and see if there is an audio item
// then we pass that on, otherwise we just pass the first item since it is probably an audio file
elseif (!(substr($enclosure->get_type(), 0, 5) === 'audio')) {
if (!(substr($enclosure->get_type(), 0, 5) === 'audio')) {
// this is a rather hackish way of accessing the enclosures but get_enclosures() didnt detect multiple
// enclosures at certain points so we search through them and then manually create an enclosure object
// if we find an audio file in an enclosure and send it off
@ -417,11 +458,12 @@ class Application_Service_PodcastEpisodeService extends Application_Service_Thir
if (is_array($testenclosures)) {
$numenclosures = sizeof($testenclosures);
// now we loop through and look for a audio file and then stop the loop at the first one we find
for ($i = 0; $i < $numenclosures + 1; $i++) {
for ($i = 0; $i < $numenclosures + 1; ++$i) {
$enclosure_attribs = array_values($testenclosures[$i]['attribs'])[0];
if (stripos($enclosure_attribs['type'], 'audio') !== false) {
$url = $enclosure_attribs['url'];
$enclosure = new SimplePie_Enclosure($enclosure_attribs['url'], $enclosure_attribs['type'], $length = $enclosure_attribs['length']);
break;
}
// if we didn't find an audio file we need to continue because there were no audio item enclosures
@ -430,8 +472,7 @@ class Application_Service_PodcastEpisodeService extends Application_Service_Thir
continue;
}
}
}
else {
} else {
continue;
}
} else {
@ -441,38 +482,40 @@ class Application_Service_PodcastEpisodeService extends Application_Service_Thir
$itemId = $item->get_id();
$ingested = in_array($itemId, $episodeIds) ? (empty($episodeFiles[$itemId]) ? -1 : 1) : 0;
$file = $ingested > 0 && !empty($episodeFiles[$itemId]) ?
CcFiles::getSanitizedFileById($episodeFiles[$itemId]) : array();
CcFiles::getSanitizedFileById($episodeFiles[$itemId]) : [];
// If the analyzer hasn't finished with the file, leave it as pending
if (!empty($file) && $file["import_status"] == CcFiles::IMPORT_STATUS_PENDING) {
if (!empty($file) && $file['import_status'] == CcFiles::IMPORT_STATUS_PENDING) {
$ingested = -1;
}
array_push($episodesArray, array(
"podcast_id" => $podcast->getDbId(),
"guid" => $itemId,
"ingested" => $ingested,
"title" => $item->get_title(),
array_push($episodesArray, [
'podcast_id' => $podcast->getDbId(),
'guid' => $itemId,
'ingested' => $ingested,
'title' => $item->get_title(),
// From the RSS spec best practices:
// 'An item's author element provides the e-mail address of the person who wrote the item'
"author" => $this->_buildAuthorString($item),
"description" => htmlspecialchars($item->get_description()),
"pub_date" => $item->get_gmdate(),
"link" => $url,
"enclosure" => $enclosure,
"file" => $file
));
'author' => $this->_buildAuthorString($item),
'description' => htmlspecialchars($item->get_description()),
'pub_date' => $item->get_gmdate(),
'link' => $url,
'enclosure' => $enclosure,
'file' => $file,
]);
}
return $episodesArray;
}
/**
* Construct a string representation of the author fields of a SimplePie_Item object
* Construct a string representation of the author fields of a SimplePie_Item object.
*
* @param SimplePie_Item $item the SimplePie_Item to extract the author data from
*
* @return string the string representation of the author data
*/
private function _buildAuthorString(SimplePie_Item $item) {
private function _buildAuthorString(SimplePie_Item $item)
{
$authorString = $author = $item->get_author();
if (!empty($author)) {
$authorString = $author->get_email();
@ -499,5 +542,4 @@ class Application_Service_PodcastEpisodeService extends Application_Service_Thir
unset($data[$key]);
}
}
}