style(legacy): format using php-cs-fixer

legacy/application/controllers/plugins/Acl_plugin.php

@@ -21,7 +21,7 @@ class Zend_Controller_Plugin_Acl extends Zend_Controller_Plugin_Abstract
      * Constructor.
      *
      * @param mixed $aclData
-     * @param $roleName
+     * @param mixed $roleName
      */
     public function __construct(Zend_Acl $aclData, $roleName = 'G')
     {

legacy/application/forms/Login.php

@@ -94,8 +94,8 @@ class Application_Form_Login extends Zend_Form
      *
      * @see <https://github.com/phingofficial/phing/blob/41b2f54108018cf69aaa73904fade23e5adfd0cc/classes/phing/util/StringHelper.php>
      *
-     * @param $check
+     * @param mixed $check
-     * @param $string
+     * @param mixed $string
      *
      * @return bool
      */

legacy/application/models/Scheduler.php

@@ -618,9 +618,9 @@ final class Application_Model_Scheduler
      *     cc_schedule items, where the items get inserted after
      * @param $filesToInsert
      *     array of schedule item info, what gets inserted into cc_schedule
-     * @param $adjustSched
      * @param mixed $mediaItems
      * @param mixed $moveAction
+     * @param mixed $adjustSched
      */
     private function insertAfter($scheduleItems, $mediaItems, $filesToInsert = null, $adjustSched = true, $moveAction = false)
     {

legacy/application/models/airtime/CcFiles.php

@@ -52,7 +52,7 @@ class CcFiles extends BaseCcFiles
     /**
      * Retrieve a sanitized version of the file metadata, suitable for public access.
      *
-     * @param $fileId
+     * @param mixed $fileId
      */
     public static function getSanitizedFileById($fileId)
     {

legacy/application/services/MediaService.php

@@ -13,11 +13,11 @@ class Application_Service_MediaService
     /** Move (or copy) a file to the stor/organize directory and send it off to the
      * analyzer to be processed.
      *
-     * @param $fileId
      * @param $filePath string Path to the local file to import to the library
      * @param $originalFilename string The original filename, if you want it to be preserved after import
      * @param $ownerId string The ID of the user that will own the file inside Airtime
      * @param $copyFile bool True if you want to copy the file to the "organize" directory, false if you want to move it (default)
+     * @param mixed $fileId
      *
      * @return Ambigous
      *
@@ -44,8 +44,8 @@ class Application_Service_MediaService
     }
 
     /**
-     * @param $fileId
+     * @param bool  $inline Set the Content-Disposition header to inline to prevent a download dialog from popping up (or attachment if false)
-     * @param bool $inline Set the Content-Disposition header to inline to prevent a download dialog from popping up (or attachment if false)
+     * @param mixed $fileId
      *
      * @throws Exception
      * @throws LibreTimeFileNotFoundException

legacy/application/services/PodcastEpisodeService.php

@@ -318,7 +318,7 @@ class Application_Service_PodcastEpisodeService extends Application_Service_Thir
     }
 
     /**
-     * @param $episodeId
+     * @param mixed $episodeId
      *
      * @return array
      *
@@ -337,11 +337,11 @@ class Application_Service_PodcastEpisodeService extends Application_Service_Thir
     /**
      * Returns an array of Podcast episodes, with the option to paginate the results.
      *
-     * @param $podcastId
      * @param int    $offset
      * @param int    $limit
      * @param string $sortColumn
      * @param string $sortDir    "ASC" || "DESC"
+     * @param mixed  $podcastId
      *
      * @return array
      *

legacy/application/services/PodcastService.php

@@ -142,9 +142,9 @@ class Application_Service_PodcastService
     }
 
     /**
-     * @param $podcast
      * @param $title passed in directly from web UI input
      * This will automatically create a smartblock and playlist for this podcast
+     * @param mixed $podcast
      */
     public static function createPodcastSmartblockAndPlaylist($podcast, $title = null)
     {
@@ -276,7 +276,7 @@ class Application_Service_PodcastService
      * Fetches a Podcast's rss feed and returns all its episodes with
      * the Podcast object.
      *
-     * @param $podcastId
+     * @param mixed $podcastId
      *
      * @return array - Podcast Array with a full list of episodes
      *
@@ -299,7 +299,7 @@ class Application_Service_PodcastService
     /**
      * Deletes a Podcast and its podcast episodes.
      *
-     * @param $podcastId
+     * @param mixed $podcastId
      *
      * @throws Exception
      * @throws PodcastNotFoundException
@@ -346,8 +346,8 @@ class Application_Service_PodcastService
     /**
      * Updates a Podcast object with the given metadata.
      *
-     * @param $podcastId
+     * @param mixed $podcastId
-     * @param $data
+     * @param mixed $data
      *
      * @return array
      *

legacy/application/services/SchedulerService.php

@@ -43,8 +43,8 @@ class Application_Service_SchedulerService
     /**
      * Applies the show start difference to any scheduled items.
      *
-     * @param $instanceIds
      * @param $diff (integer, difference between unix epoch in seconds)
+     * @param mixed $instanceIds
      */
     public static function updateScheduleStartTime($instanceIds, $diff)
     {
@@ -278,10 +278,10 @@ class Application_Service_SchedulerService
                         $values[] = '(' . "'{$nextStartDT->format(DEFAULT_TIMESTAMP_FORMAT)}', " .
                             "'{$endTimeDT->format(DEFAULT_TIMESTAMP_FORMAT)}', " .
                             "'{$item['clip_length']}', " .
-                            "'{$item['fade_in']}', " . "'{$item['fade_out']}', " .
+                            "'{$item['fade_in']}', '{$item['fade_out']}', " .
-                            "'{$item['cue_in']}', " . "'{$item['cue_out']}', " .
+                            "'{$item['cue_in']}', '{$item['cue_out']}', " .
-                            "{$item['file_id']}, " . "{$item['stream_id']}, " .
+                            "{$item['file_id']}, {$item['stream_id']}, " .
-                            "{$id}, " . "{$item['position']})";
+                            "{$id}, {$item['position']})";
 
                         $nextStartDT = self::findTimeDifference(
                             $endTimeDT,

legacy/application/services/ShowFormService.php

@@ -121,7 +121,7 @@ class Application_Service_ShowFormService
      * Delegates populating each show form with the appropriate
      * data of the current show being edited.
      *
-     * @param $forms
+     * @param mixed $forms
      */
     public function delegateShowFormPopulation($forms)
     {
@@ -284,8 +284,8 @@ class Application_Service_ShowFormService
     /**
      * Enter description here ...
      *
-     * @param $form
      * @param DateTime $nextFutureShowStart user's local timezone
+     * @param mixed    $form
      */
     private function populateFormRepeats($form, $nextFutureShowStart)
     {
@@ -488,7 +488,7 @@ class Application_Service_ShowFormService
      * Before we send the form data in for validation, there
      * are a few fields we may need to adjust first.
      *
-     * @param $formData
+     * @param mixed $formData
      */
     public function preEditShowValidationCheck($formData)
     {

legacy/application/services/ShowService.php

@@ -302,7 +302,7 @@ class Application_Service_ShowService
      * Adjusts the items in cc_schedule to reflect the
      * new (if one) start and end time of the show getting updated.
      *
-     * @param $showData
+     * @param mixed $showData
      */
     private function adjustSchedule($showData)
     {
@@ -759,7 +759,7 @@ SQL;
      *     (days of the week are represented numerically
      *      0=>sunday, 1=>monday, 2=>tuesday, etc.)
      * @param $showDays array of ccShowDays objects
-     * @param $showId
+     * @param mixed $showId
      */
     private function deleteRemovedShowDayInstances($daysRemoved, $showDays, $showId)
     {
@@ -1116,7 +1116,7 @@ SQL;
      *
      * @param ccShowDays $showDay
      * @param DateTime   $showStartDate user's local time
-     * @param $instanceId
+     * @param mixed      $instanceId
      */
     private function createRebroadcastInstances($showDay, $showStartDate, $instanceId)
     {
@@ -1157,8 +1157,8 @@ SQL;
     /**
      * Sets a single cc_show_instance table row.
      *
-     * @param $showDay
+     * @param mixed $showDay
-     * @param $populateUntil
+     * @param mixed $populateUntil
      */
     private function createNonRepeatingInstance($showDay, $populateUntil)
     {
@@ -1647,7 +1647,7 @@ SQL;
      * Sets the fields for a cc_show table row.
      *
      * @param $ccShow
-     * @param $showData
+     * @param mixed $showData
      */
     public function setCcShow($showData)
     {
@@ -1691,12 +1691,12 @@ SQL;
     /**
      * Sets the fields for a cc_show_days table row.
      *
-     * @param $showData
      * @param $showId
      * @param $userId
      * @param $repeatType
      * @param $isRecorded
      * @param $showDay ccShowDay object we are setting values on
+     * @param mixed $showData
      */
     private function setCcShowDays($showData)
     {
@@ -1824,10 +1824,10 @@ SQL;
     /**
      * Sets the fields for a cc_show_rebroadcast table row.
      *
-     * @param $showData
      * @param $showId
      * @param $repeatType
      * @param $isRecorded
+     * @param mixed $showData
      */
     private function setCcShowRebroadcasts($showData)
     {
@@ -1873,8 +1873,8 @@ SQL;
     /**
      * Sets the fields for a cc_show_hosts table row.
      *
-     * @param $showData
      * @param $showId
+     * @param mixed $showData
      */
     private function setCcShowHosts($showData)
     {
@@ -1946,9 +1946,9 @@ SQL;
      * date for when the next repeating show instance should be created
      * as the user browses the calendar further.
      *
-     * @param $nextDate
+     * @param mixed $nextDate
-     * @param $showId
+     * @param mixed $day
-     * @param $day
+     * @param mixed $showId
      */
     private function setNextRepeatingShowDate($nextDate, $day, $showId)
     {