CC-2873: Use PHP constants

- done

airtime_mvc/application/configs/constants.php

@@ -35,3 +35,7 @@ define('UI_MDATA_VALUE_FORMAT_STREAM', 'live stream');
 // Session Keys
 define('UI_PLAYLIST_SESSNAME', 'PLAYLIST');
 
+
+// Soundcloud contants
+define('SC_PROGRESS', -2);
+define('SC_ERROR', -2);

airtime_mvc/application/controllers/ApiController.php

@@ -413,7 +413,7 @@ class ApiController extends Zend_Controller_Action
                     $this->setSoundCloudErrorCode($code);
                     $this->setSoundCloudErrorMsg($msg);
                     // setting sc id to -3 which indicates error
-                    $this->setSoundCloudFileId(-3);
+                    $this->setSoundCloudFileId(SC_ERROR);
         			if(!in_array($code, array(0, 100))) {
         				break;
         			}

utils/soundcloud-uploader.php

@@ -60,6 +60,6 @@ if(count($argv) != 2){
 $id = $argv[1];
 $file = Application_Model_StoredFile::Recall($id);
 // set id with -2 which is indicator for processing
-$file->setSoundCloudFileId(-2);
+$file->setSoundCloudFileId(SC_PROGRESS);
 $file->uploadToSoundCloud();