Congegni
/
sintonia
7
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

chore(api): rename editor role to host

This commit is contained in:
jo 2022-06-27 17:13:05 +02:00 committed by Kyle Robbertze
parent 4009e7eeb6
commit e730959e9f
5 changed files with 16 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
api/libretime_api/core/models/role.py
View File

@ -3,6 +3,6 @@ from django.db import models
class Role(models.TextChoices): class Role(models.TextChoices):
GUEST = "G", "Guest" GUEST = "G", "Guest"
EDITOR = "H", "Editor" HOST = "H", "Host"
MANAGER = "P", "Manager" MANAGER = "P", "Manager"
ADMIN = "A", "Admin" ADMIN = "A", "Admin"

2
api/libretime_api/core/tests/models/test_user.py
View File

@ -7,7 +7,7 @@ from ...models import Role, User
class TestUserManager(APITestCase): class TestUserManager(APITestCase):
def test_create_user(self): def test_create_user(self):
user = User.objects.create_user( user = User.objects.create_user(
role=Role.EDITOR, role=Role.HOST,
username="test", username="test",
password="test", password="test",
email="test@example.com", email="test@example.com",

4
api/libretime_api/permission_constants.py
View File

@ -19,7 +19,7 @@ GUEST_PERMISSIONS = [
"view_apiroot", "view_apiroot",
] ]
EDITOR_PERMISSIONS = GUEST_PERMISSIONS + [ HOST_PERMISSIONS = GUEST_PERMISSIONS + [
"add_file", "add_file",
"add_podcast", "add_podcast",
"add_podcastepisode", "add_podcastepisode",
@ -100,6 +100,6 @@ MANAGER_PERMISSIONS = GUEST_PERMISSIONS + [
GROUPS = { GROUPS = {
Role.GUEST.value: GUEST_PERMISSIONS, Role.GUEST.value: GUEST_PERMISSIONS,
Role.EDITOR.value: EDITOR_PERMISSIONS, Role.HOST.value: HOST_PERMISSIONS,
Role.MANAGER.value: MANAGER_PERMISSIONS, Role.MANAGER.value: MANAGER_PERMISSIONS,
} }

2
api/libretime_api/permissions.py
View File

@ -18,7 +18,7 @@ REQUEST_PERMISSION_TYPE_MAP = {
def get_own_obj(request, view): def get_own_obj(request, view):
user = request.user user = request.user
if user is None or user.role != Role.EDITOR: if user is None or user.role != Role.HOST:
return "" return ""
if request.method == "GET": if request.method == "GET":
return "" return ""

22
api/libretime_api/tests/test_permissions.py
View File

@ -97,12 +97,12 @@ class TestPermissions(APITestCase):
msg=f"Invalid for model {model}", msg=f"Invalid for model {model}",
) )
def test_editor_get_permissions(self): def test_host_get_permissions(self):
for model in self.URLS: for model in self.URLS:
response = self.logged_in_test_model( response = self.logged_in_test_model(
model, model,
Role.EDITOR, Role.HOST,
"editor", "host",
self.client.get, self.client.get,
) )
self.assertEqual( self.assertEqual(
@ -111,10 +111,10 @@ class TestPermissions(APITestCase):
msg=f"Invalid for model {model}", msg=f"Invalid for model {model}",
) )
def test_editor_post_permissions(self): def test_host_post_permissions(self):
user = get_user_model().objects.create_user( user = get_user_model().objects.create_user(
role=Role.EDITOR, role=Role.HOST,
username="editor2", username="host2",
password="test", password="test",
email="test@example.com", email="test@example.com",
first_name="test", first_name="test",
@ -123,14 +123,14 @@ class TestPermissions(APITestCase):
file = baker.make("storage.File", owner=user) file = baker.make("storage.File", owner=user)
model = f"files/{file.id}" model = f"files/{file.id}"
path = self.path.format(model) path = self.path.format(model)
self.client.login(username="editor2", password="test") self.client.login(username="host2", password="test")
response = self.client.patch(path, {"name": "newFilename"}) response = self.client.patch(path, {"name": "newFilename"})
self.assertEqual(response.status_code, 200) self.assertEqual(response.status_code, 200)
def test_editor_post_permissions_failure(self): def test_host_post_permissions_failure(self):
get_user_model().objects.create_user( get_user_model().objects.create_user(
role=Role.EDITOR, role=Role.HOST,
username="editor2", username="host2",
password="test", password="test",
email="test@example.com", email="test@example.com",
first_name="test", first_name="test",
@ -139,6 +139,6 @@ class TestPermissions(APITestCase):
file = baker.make("storage.File") file = baker.make("storage.File")
model = f"files/{file.id}" model = f"files/{file.id}"
path = self.path.format(model) path = self.path.format(model)
self.client.login(username="editor2", password="test") self.client.login(username="host2", password="test")
response = self.client.patch(path, {"name": "newFilename"}) response = self.client.patch(path, {"name": "newFilename"})
self.assertEqual(response.status_code, 403) self.assertEqual(response.status_code, 403)