Merge branch 'saas-dev' into soundcloud

airtime_mvc/application/common/HTTPHelper.php

@@ -42,3 +42,33 @@ class Application_Common_HTTPHelper
         return $stationUrl;
     }
 }
+
+class ZendActionHttpException extends Exception {
+
+    private $_action;
+
+    /**
+     * @param Zend_Controller_Action $action
+     * @param int                    $statusCode
+     * @param string                 $message
+     * @param int                    $code
+     * @param Exception              $previous
+     *
+     * @throws Zend_Controller_Response_Exception
+     */
+    public function __construct(Zend_Controller_Action $action, $statusCode, $message,
+                                $code = 0, Exception $previous = null) {
+        $this->_action = $action;
+        Logging::info("Error in action " . $action->getRequest()->getActionName()
+                      . " with status code $statusCode: $message");
+        $action->getResponse()
+            ->setHttpResponseCode($statusCode)
+            ->appendBody($message);
+        parent::__construct($message, $code, $previous);
+    }
+
+    public function getAction() {
+        return $this->_action;
+    }
+
+}

airtime_mvc/application/controllers/ApiController.php

@@ -73,6 +73,7 @@ class ApiController extends Zend_Controller_Action
             print _('You are not allowed to access this resource.');
             exit;
         }
+        return true;
     }
 
     public function versionAction()
@@ -157,7 +158,7 @@ class ApiController extends Zend_Controller_Action
      */
     public function liveInfoAction()
     {
-        if (Application_Model_Preference::GetAllow3rdPartyApi()) {
+        if (Application_Model_Preference::GetAllow3rdPartyApi() || $this->checkAuth()) {
             // disable the view and the layout
             $this->view->layout()->disableLayout();
             $this->_helper->viewRenderer->setNoRender(true);
@@ -252,7 +253,7 @@ class ApiController extends Zend_Controller_Action
      */
     public function liveInfoV2Action()
     {
-        if (Application_Model_Preference::GetAllow3rdPartyApi()) {
+        if (Application_Model_Preference::GetAllow3rdPartyApi() || $this->checkAuth()) {
             // disable the view and the layout
             $this->view->layout()->disableLayout();
             $this->_helper->viewRenderer->setNoRender(true);
@@ -360,7 +361,7 @@ class ApiController extends Zend_Controller_Action
     
     public function weekInfoAction()
     {
-        if (Application_Model_Preference::GetAllow3rdPartyApi()) {
+        if (Application_Model_Preference::GetAllow3rdPartyApi() || $this->checkAuth()) {
             // disable the view and the layout
             $this->view->layout()->disableLayout();
             $this->_helper->viewRenderer->setNoRender(true);
@@ -434,8 +435,8 @@ class ApiController extends Zend_Controller_Action
      * Go through a given array and sanitize any potentially exploitable fields
      * by passing them through htmlspecialchars
      *
-     * @param unknown $arr    the array to sanitize
+     * @param array $arr     the array to sanitize
-     * @param unknown $keys    indexes of values to be sanitized
+     * @param array $keys    indexes of values to be sanitized
      */
     private function convertSpecialChars(&$arr, $keys) 
     {
@@ -455,7 +456,7 @@ class ApiController extends Zend_Controller_Action
      * Recursively find image_path keys in the various $result subarrays,
      * and convert them to point to the show-logo endpoint
      *
-     * @param unknown $arr the array to search
+     * @param array $arr the array to search
      */
     private function findAndConvertPaths(&$arr) 
     {
@@ -479,25 +480,37 @@ class ApiController extends Zend_Controller_Action
      */
     public function showLogoAction() 
     {
-        if (Application_Model_Preference::GetAllow3rdPartyApi()) {
+        // Disable the view and the layout
-            $request = $this->getRequest();
-            $showId = $request->getParam('id');
-
-            // if no id is passed, just die - redirects to a 404
-            if (!$showId || $showId === '') {
-                return;
-            }
-
-            $show = CcShowQuery::create()->findPk($showId);
-            
-            // disable the view and the layout
         $this->view->layout()->disableLayout();
         $this->_helper->viewRenderer->setNoRender(true);
 
+        if (Application_Model_Preference::GetAllow3rdPartyApi() || $this->checkAuth()) {
+            $request = $this->getRequest();
+            $showId = $request->getParam('id');
+            if (empty($showId)) {
+                throw new ZendActionHttpException($this, 400, "ERROR: No ID was given.");
+            }
+
+            $show = CcShowQuery::create()->findPk($showId);
+            if (empty($show)) {
+                throw new ZendActionHttpException($this, 400, "ERROR: No show with ID $showId exists.");
+            }
+            
             $path = $show->getDbImagePath();
             $mime_type = mime_content_type($path);
+            if (empty($path)) {
+                throw new ZendActionHttpException($this, 400, "ERROR: Show does not have an associated image.");
+            }
 
+            try {
+                // Sometimes end users may be looking at stale data - if an image is removed
+                // but has been cached in a client's browser this will throw an exception
                 Application_Common_FileIO::smartReadFile($path, filesize($path), $mime_type);
+            } catch(FileNotFoundException $e) {
+                throw new ZendActionHttpException($this, 404, "ERROR: No image found at $path");
+            } catch(Exception $e) {
+                throw new ZendActionHttpException($this, 500, "ERROR: " . $e->getMessage());
+            }
         } else {
             header('HTTP/1.0 401 Unauthorized');
             print _('You are not allowed to access this resource. ');
@@ -510,7 +523,7 @@ class ApiController extends Zend_Controller_Action
      */
     public function stationMetadataAction()
     {
-        if (Application_Model_Preference::GetAllow3rdPartyApi()) {
+        if (Application_Model_Preference::GetAllow3rdPartyApi() || $this->checkAuth()) {
             // disable the view and the layout
             $this->view->layout()->disableLayout();
             $this->_helper->viewRenderer->setNoRender(true);
@@ -549,7 +562,7 @@ class ApiController extends Zend_Controller_Action
      */
     public function stationLogoAction() 
     {
-        if (Application_Model_Preference::GetAllow3rdPartyApi()) {
+        if (Application_Model_Preference::GetAllow3rdPartyApi() || $this->checkAuth()) {
             // disable the view and the layout
             $this->view->layout()->disableLayout();
             $this->_helper->viewRenderer->setNoRender(true);

airtime_mvc/application/controllers/IndexController.php

@@ -10,7 +10,7 @@ class IndexController extends Zend_Controller_Action
 
     public function indexAction()
     {
-        $this->_forward('index', 'showbuilder');
+        $this->_redirect('Showbuilder');
     }
 
     public function mainAction()

airtime_mvc/application/controllers/PreferenceController.php

@@ -67,6 +67,7 @@ class PreferenceController extends Zend_Controller_Action
                 Application_Model_Preference::setDefaultSoundCloudSharingType($values["SoundCloudSharing"]);
 
                 $this->view->statusMsg = "<div class='success'>". _("Preferences updated.")."</div>";
+                $form = new Application_Form_Preferences();
                 $this->view->form = $form;
                 //$this->_helper->json->sendJson(array("valid"=>"true", "html"=>$this->view->render('preference/index.phtml')));
             } else {

airtime_mvc/application/controllers/UserController.php

@@ -144,14 +144,27 @@ class UserController extends Zend_Controller_Action
                 // We don't allow 6 x's as a password.
                 // The reason is because we use that as a password placeholder
                 // on the client side.
-                if (($formData['cu_password'] != "xxxxxx") &&
+                if (array_key_exists('cu_password', $formData) && ($formData['cu_password'] != "xxxxxx") &&
                     (!empty($formData['cu_password']))) {
                     $user->setPassword($formData['cu_password']);
                 }
+
+                if (array_key_exists('cu_email', $formData)) {
                     $user->setEmail($formData['cu_email']);
+                }
+
+                if (array_key_exists('cu_cell_phone', $formData)) {
                     $user->setCellPhone($formData['cu_cell_phone']);
+                }
+
+                if (array_key_exists('cu_skype', $formData)) {
                     $user->setSkype($formData['cu_skype']);
+                }
+
+                if (array_key_exists('cu_jabber', $formData)) {
                     $user->setJabber($formData['cu_jabber']);
+                }
+
                 $user->save();
 
                 Application_Model_Preference::SetUserLocale($formData['cu_locale']);

airtime_mvc/application/controllers/WhmcsLoginController.php

@@ -239,7 +239,7 @@ class WHMCS_Auth_Adapter implements Zend_Auth_Adapter_Interface {
             }
             else
             {
-                if ($product["status"] === "Active") {
+                if (($product["status"] === "Active") || ($product["status"] === "Suspended")) {
                     $airtimeProduct = $product;
                     $subdomain = '';
 

airtime_mvc/application/forms/TuneInPreferences.php

@@ -18,7 +18,6 @@ class Application_Form_TuneInPreferences extends Zend_Form_SubForm
         $enableTunein->addDecorator('Label', array('class' => 'enable-tunein'));
         $enableTunein->setLabel(_("Push metadata to your station on TuneIn?"));
         $enableTunein->setValue(Application_Model_Preference::getTuneinEnabled());
-        $enableTunein->setAttrib("class", "block-display");
         $this->addElement($enableTunein);
 
         $tuneinStationId = new Zend_Form_Element_Text("tunein_station_id");
@@ -76,7 +75,6 @@ class Application_Form_TuneInPreferences extends Zend_Form_SubForm
                 Logging::error("Failed to reach TuneIn: ". curl_errno($ch)." - ". curl_error($ch) . " - " . curl_getinfo($ch, CURLINFO_EFFECTIVE_URL));
                 if (curl_error($ch) == "The requested URL returned error: 403 Forbidden") {
                     $this->getElement("enable_tunein")->setErrors(array(_("Invalid TuneIn Settings. Please ensure your TuneIn settings are correct and try again.")));
-
                     $valid = false;
                 }
             }
@@ -85,6 +83,7 @@ class Application_Form_TuneInPreferences extends Zend_Form_SubForm
             if ($valid) {
                 $xmlObj = new SimpleXMLElement($xmlData);
                 if (!$xmlObj || $xmlObj->head->status != "200") {
+                    $this->getElement("enable_tunein")->setErrors(array(_("Invalid TuneIn Settings. Please ensure your TuneIn settings are correct and try again.")));
                     $valid = false;
                 } else if ($xmlObj->head->status == "200") {
                     Application_Model_Preference::setLastTuneinMetadataUpdate(time());

airtime_mvc/application/models/Schedule.php

@@ -199,7 +199,6 @@ SQL;
             $currentMedia["ends"] = $currentMedia["show_ends"];
         }
 
-        $currentMediaScheduleId = $currentMedia["id"];
         $currentMediaFileId = $currentMedia["file_id"];
         $currentMediaStreamId = $currentMedia["stream_id"];
         if (isset($currentMediaFileId)) {
@@ -234,9 +233,10 @@ SQL;
         );
 
         $previousMedia = CcScheduleQuery::create()
-            ->filterByDbId($currentMediaScheduleId-1)
+            ->filterByDbStarts($currentMedia["starts"], Criteria::LESS_THAN)
+            ->filterByDbId($currentMedia["id"], Criteria::NOT_EQUAL)
             ->filterByDbPlayoutStatus(0, Criteria::GREATER_THAN)
-            ->orderByDbStarts()
+            ->orderByDbStarts(Criteria::DESC)
             ->findOne();
         if (isset($previousMedia)) {
             $previousMediaFileId = $previousMedia->getDbFileId();
@@ -253,10 +253,6 @@ SQL;
                 $previousWebstream = CcWebstreamQuery::create()
                     ->filterByDbId($previousMediaStreamId)
                     ->findOne();
-                /*$previousWebstreamMetadata = CcWebstreamMetadataQuery::create()
-                    ->filterByDbInstanceId($previousMedia->getDbInstanceId())
-                    ->orderByDbStartTime(Criteria::DESC)
-                    ->findOne();*/
                 $previousMediaName = $previousWebstream->getDbName();
             } else {
                 $previousMediaType = null;
@@ -270,8 +266,9 @@ SQL;
         }
 
         $nextMedia = CcScheduleQuery::create()
-            ->filterByDbId($currentMediaScheduleId+1)
+            ->filterByDbStarts($currentMedia["starts"], Criteria::GREATER_THAN)
-            ->orderByDbStarts()
+            ->filterByDbId($currentMedia["id"], Criteria::NOT_EQUAL)
+            ->orderByDbStarts(Criteria::ASC)
             ->findOne();
         if (isset($nextMedia)) {
             $nextMediaFileId = $nextMedia->getDbFileId();
@@ -287,10 +284,6 @@ SQL;
                 $nextWebstream = CcWebstreamQuery::create()
                     ->filterByDbId($nextMediaStreamId)
                     ->findOne();
-                /*$nextWebstreamMetadata = CcWebstreamMetadataQuery::create()
-                    ->filterByDbInstanceId($nextMedia->getDbInstanceId())
-                    ->orderByDbStartTime(Criteria::DESC)
-                    ->findOne();*/
                 $nextMediaName = $nextWebstream->getDbName();
             } else {
                 $nextMediaType = null;

airtime_mvc/application/models/Show.php

@@ -1163,7 +1163,7 @@ ORDER BY
       AND  si.starts < :timeNow::timestamp THEN 1
     WHEN si.starts > :timeNow::timestamp THEN 2
     ELSE 3
-  END
+  END, si.starts
 LIMIT :lim
 SQL;
 

airtime_mvc/application/modules/rest/controllers/ShowImageController.php

@@ -56,12 +56,13 @@ class Rest_ShowImageController extends Zend_Rest_Controller {
             $this->getResponse()
                 ->setHttpResponseCode(500)
                 ->appendBody("Error processing image: " . $e->getMessage());
+            return;
         }
 
         $show = CcShowQuery::create()->findPk($showId);
 
-        try {
         $con = Propel::getConnection();
+        try {
             $con->beginTransaction();
 
             $show->setDbImagePath($path);
@@ -103,8 +104,8 @@ class Rest_ShowImageController extends Zend_Rest_Controller {
 
         $show = CcShowQuery::create()->findPk($showId);
 
-        try {
         $con = Propel::getConnection();
+        try {
             $con->beginTransaction();
 
             $show->setDbImagePath(null);
@@ -268,7 +269,7 @@ class Rest_ShowImageController extends Zend_Rest_Controller {
     private static function delTree($dir) {
         $files = array_diff(scandir($dir), array('.', '..'));
         foreach ($files as $file) {
-            (is_dir("$dir/$file")) ? delTree("$dir/$file") : unlink("$dir/$file");
+            (is_dir("$dir/$file")) ? self::delTree("$dir/$file") : unlink("$dir/$file");
         }
         return rmdir($dir);
     }
@@ -279,7 +280,7 @@ class Rest_ShowImageController extends Zend_Rest_Controller {
      * provided, otherwise returns the id
      */
     private function getShowId() {
-        if (!$id = $this->_getParam('id', false)) {
+        if (!($id = $this->_getParam('id', false))) {
             $resp = $this->getResponse();
             $resp->setHttpResponseCode(400);
             $resp->appendBody("ERROR: No show ID specified.");

python_apps/pypo/liquidsoap_scripts/generate_liquidsoap_cfg.py

@@ -14,6 +14,8 @@ def generate_liquidsoap_config(ss):
 
     for key, value in data.iteritems():
         try:
+            if not "port" in key and not "bitrate" in key: # Stupid hack
+                raise ValueError()
             str_buffer = "%s = %s\n" % (key, int(value))
         except ValueError:
             try: # Is it a boolean?

python_apps/pypo/pypofetch.py

@@ -477,6 +477,7 @@ class PypoFetch(Thread):
         loops = 1
         while True:
             self.logger.info("Loop #%s", loops)
+            manual_fetch_needed = False
             try:
                 """
                 our simple_queue.get() requires a timeout, in which case we
@@ -492,17 +493,26 @@ class PypoFetch(Thread):
                 Currently we are checking every POLL_INTERVAL seconds
                 """
 
-
                 message = self.fetch_queue.get(block=True, timeout=self.listener_timeout)
+                manual_fetch_needed = False
                 self.handle_message(message)
-            except Empty, e:
+            except Empty as e:
                 self.logger.info("Queue timeout. Fetching schedule manually")
-                self.persistent_manual_schedule_fetch(max_attempts=5)
+                manual_fetch_needed = True
-            except Exception, e:
+            except Exception as e:
                 top = traceback.format_exc()
                 self.logger.error('Exception: %s', e)
                 self.logger.error("traceback: %s", top)
 
+            try:
+                if manual_fetch_needed:
+                    self.persistent_manual_schedule_fetch(max_attempts=5)
+            except Exception as e:
+                top = traceback.format_exc()
+                self.logger.error('Failed to manually fetch the schedule.')
+                self.logger.error('Exception: %s', e)
+                self.logger.error("traceback: %s", top)
+
             loops += 1
 
     def run(self):
@@ -510,3 +520,4 @@ class PypoFetch(Thread):
         Entry point of the thread
         """
         self.main()
+        self.logger.info('PypoFetch thread exiting')

python_apps/pypo/pypofile.py

@@ -35,6 +35,7 @@ class PypoFile(Thread):
         self.media_queue = schedule_queue
         self.media = None
         self.cache_dir = os.path.join(config["cache_dir"], "scheduler")
+        self._config = self.read_config_file(CONFIG_PATH)
 
     def copy_file(self, media_item):
         """
@@ -65,11 +66,9 @@ class PypoFile(Thread):
         if do_copy:
             self.logger.debug("copying from %s to local cache %s" % (src, dst))
             try:
-                config = self.read_config_file(CONFIG_PATH)
                 CONFIG_SECTION = "general"
-                username = config.get(CONFIG_SECTION, 'api_key')
+                username = self._config.get(CONFIG_SECTION, 'api_key')
-
+                host = self._config.get(CONFIG_SECTION, 'base_url')
-                host = config.get(CONFIG_SECTION, 'base_url')
                 url = "http://%s/rest/media/%s/download" % (host, media_item["id"])
                 with open(dst, "wb") as handle:
                     response = requests.get(url, auth=requests.auth.HTTPBasicAuth(username, ''), stream=True, verify=False)
@@ -210,3 +209,4 @@ class PypoFile(Thread):
         Entry point of the thread
         """
         self.main()
+