Congegni
/
sintonia
7
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

added error checked for required params

This commit is contained in:
Mark Lewis 2015-01-08 19:52:06 +01:00 committed by Albert Santoni
parent 1cc1f8a378
commit fc8e65944e
1 changed files with 24 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
airtime_mvc/application/controllers/ApiController.php
View File

@ -1424,9 +1424,22 @@ class ApiController extends Zend_Controller_Action
$showId = $request->getParam("show_id", null); $showId = $request->getParam("show_id", null);
list($startsDT, $endsDT) = Application_Common_HTTPHelper::getStartEndFromRequest($request); list($startsDT, $endsDT) = Application_Common_HTTPHelper::getStartEndFromRequest($request);
if ((!isset($showId)) || (!is_int($showId))) {
$this->_helper->json->sendJson(
array("jsonrpc" => "2.0", "error" => array("code" => 400, "message" => "missing invalid type for required show_id parameter. use type int"))
);
}
$shows = Application_Model_Show::getShows($startsDT, $endsDT, FALSE, $showId); $shows = Application_Model_Show::getShows($startsDT, $endsDT, FALSE, $showId);
// is this a valid show?
if (empty($shows)) {
$this->_helper->json->sendJson(
array("jsonrpc" => "2.0", "error" => array("code" => 204, "message" => "no content for requested show_id"))
);
}
$this->_helper->json->sendJson($shows); $this->_helper->json->sendJson($shows);
} }
catch (Exception $e) { catch (Exception $e) {
@ -1448,13 +1461,22 @@ class ApiController extends Zend_Controller_Action
$instanceId = $this->_getParam('instance_id'); $instanceId = $this->_getParam('instance_id');
if (!isset($instanceId)) { if ((!isset($instanceId)) || (!is_int($instanceI))) {
$this->_helper->json->sendJson( $this->_helper->json->sendJson(
array("jsonrpc" => "2.0", "error" => array("code" => 400, "message" => "missing required instance_id parameter")) array("jsonrpc" => "2.0", "error" => array("code" => 400, "message" => "missing invalid type for required instance_id parameter. use type int"))
); );
} }
$showInstance = new Application_Model_ShowInstance($instanceId); $showInstance = new Application_Model_ShowInstance($instanceId);
$showInstanceContent = $showInstance->getShowListContent($prefTimezone);
// is this a valid show instance with content?
if (empty($showInstanceContent)) {
$this->_helper->json->sendJson(
array("jsonrpc" => "2.0", "error" => array("code" => 204, "message" => "no content for requested instance_id"))
);
}
$result = array(); $result = array();
$position = 0; $position = 0;
foreach ($showInstance->getShowListContent($prefTimezone) as $track) { foreach ($showInstance->getShowListContent($prefTimezone) as $track) {