Merge pull request #75 - Saas relder csrf delete file
This commit is contained in:
parent
53dc92b204
commit
fd39db2e24
|
@ -300,12 +300,18 @@ class Rest_MediaController extends Zend_Rest_Controller
|
||||||
}
|
}
|
||||||
return $id;
|
return $id;
|
||||||
}
|
}
|
||||||
|
|
||||||
private function verifyAuth($checkApiKey, $checkSession)
|
private function verifyAuth($checkApiKey, $checkSession)
|
||||||
{
|
{
|
||||||
//Session takes precedence over API key for now:
|
// Session takes precedence over API key for now:
|
||||||
if ($checkSession && $this->verifySession())
|
if ($checkSession && $this->verifySession()) {
|
||||||
{
|
// CSRF token validation only applies to session based authorization.
|
||||||
|
if(!$this->verifyCSRFToken($this->_getParam('csrf_token'))){
|
||||||
|
$resp = $this->getResponse();
|
||||||
|
$resp->setHttpResponseCode(401);
|
||||||
|
$resp->appendBody("ERROR: Token Missmatch.");
|
||||||
|
return false;
|
||||||
|
}
|
||||||
return true;
|
return true;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -321,6 +327,17 @@ class Rest_MediaController extends Zend_Rest_Controller
|
||||||
return false;
|
return false;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
private function verifyCSRFToken($token){
|
||||||
|
$current_namespace = new Zend_Session_Namespace('csrf_namespace');
|
||||||
|
$observed_csrf_token = $token;
|
||||||
|
$expected_csrf_token = $current_namespace->authtoken;
|
||||||
|
|
||||||
|
if($observed_csrf_token == $expected_csrf_token){
|
||||||
|
return true;
|
||||||
|
}else{
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
private function verifyAPIKey()
|
private function verifyAPIKey()
|
||||||
{
|
{
|
||||||
|
|
|
@ -89,7 +89,7 @@ $(document).ready(function() {
|
||||||
|
|
||||||
$.ajax({
|
$.ajax({
|
||||||
type: 'DELETE',
|
type: 'DELETE',
|
||||||
url: '/rest/media/' + file.id,
|
url: 'rest/media/' + file.id + "?csrf_token=" + $("#csrf").attr('value'),
|
||||||
success: function(resp) {
|
success: function(resp) {
|
||||||
self.recentUploadsTable.fnDraw();
|
self.recentUploadsTable.fnDraw();
|
||||||
},
|
},
|
||||||
|
|
Loading…
Reference in New Issue