This a a rather large commit due to the nature of the stuff it is touching. To get PHPUnit up and running again I had to update some deps and I did so by vendorizing them. The vendorizing of zf1 makes sense since distros are already considering to drop it from their repos. * [x] install vendorized zf1 with composer * [x] load composer autoloader before zf1 * [x] Implement headAction for all Zend_Rest_Controller based controllers * [x] switch to yml dataset to get around string only limitations of xml sets (also removed warning in readme) * [x] use year 2044 as hardcoded date for tests since it is in the future and has the same days like previously used 2016 * [x] make tests easier to run when accessing phpunit directly * [x] clean up test helper to always use airtime.conf * [x] switch test dbname to libretime_test * [x] test db username password switched to libretime/libretime * [x] install phpunit with composer in a clear version (make tests easier to reproduce on other platforms) * [x] remove local libs from airtime repo (most of airtime_mvc/library was not needed of in vendor already) * [x] configure composer autoloading and use it (also removed requires that are not needed anymore) * [x] add LibreTime prefix for FileNotFoundException (phing had a similar class and these are all pre-namespace style) * [x] add .travis.yml file * [x] make etc and logdir configurable with LIBRETIME_CONF_DIR and LIBRETIME_LOG_DIR env (so travis can change it) * [x] slight cleanup in config for travis not to fail * [x] add cloud_storage.conf for during test runs * [x] rewrite mvc testing docs and move them to docs/ folder * [x] don't use `static::class` in a class that does not have a parent class, use `__CLASS__` instead. * [x] don't use `<ClassName>::class`, since we already know what class we want `"<ClassName>"` ist just fine. * [x] fix "can't use method in write context" errors on 5.4 (also helps the optimizer) * [x] add build status badge on main README.md Fixes https://github.com/LibreTime/libretime/issues/4 The PHP parts of https://github.com/LibreTime/libretime/pull/10 get obsoleted by this change and it will need rebasing. This also contains https://github.com/LibreTime/libretime/pull/8, the late static binding compat code was broken for no reason and until CentOS drops php 5.4 there is no reason I'm aware of not to support it. I inlined #8 since the test would be failing on php 5.4 without the change. If you want to run tests you need to run `composer install` in the root directory and then `cd airtime_mvc/tests && ../../vendor/bin/phpunit`. For the tests to run the user `libretime` needs to be allowed to create the `libretime_test` database. See `docs/TESTING.md` for more info on getting set up.
200 lines
5.8 KiB
PHP
200 lines
5.8 KiB
PHP
<?php
|
|
|
|
class Rest_PodcastEpisodesController extends Zend_Rest_Controller
|
|
{
|
|
|
|
/**
|
|
* @var Application_Service_PodcastEpisodeService
|
|
*/
|
|
protected $_service;
|
|
|
|
public function init()
|
|
{
|
|
$this->view->layout()->disableLayout();
|
|
|
|
// Remove reliance on .phtml files to render requests
|
|
$this->_helper->viewRenderer->setNoRender(true);
|
|
$this->_service = new Application_Service_PodcastEpisodeService();
|
|
}
|
|
|
|
/**
|
|
* headAction is needed as it is defined as an abstract function in the base controller
|
|
*
|
|
* @return void
|
|
*/
|
|
public function headAction()
|
|
{
|
|
Logging::info("HEAD action received");
|
|
}
|
|
|
|
public function indexAction()
|
|
{
|
|
// podcast ID
|
|
$id = $this->getId();
|
|
if (!$id) {
|
|
return;
|
|
}
|
|
try {
|
|
$totalPodcastEpisodesCount = PodcastEpisodesQuery::create()
|
|
->filterByDbPodcastId($id)
|
|
->count();
|
|
|
|
// Check if offset and limit were sent with request.
|
|
// Default limit to zero and offset to $totalFileCount
|
|
$offset = $this->_getParam('offset', 0);
|
|
$limit = $this->_getParam('limit', $totalPodcastEpisodesCount);
|
|
|
|
//Sorting parameters
|
|
$sortColumn = $this->_getParam('sort', PodcastEpisodesPeer::ID);
|
|
$sortDir = $this->_getParam('sort_dir', Criteria::ASC);
|
|
|
|
$this->getResponse()
|
|
->setHttpResponseCode(201)
|
|
->setHeader('X-TOTAL-COUNT', $totalPodcastEpisodesCount)
|
|
->appendBody(json_encode($this->_service->getPodcastEpisodes($id, $offset, $limit, $sortColumn, $sortDir)));
|
|
|
|
} catch (PodcastNotFoundException $e) {
|
|
$this->podcastNotFoundResponse();
|
|
Logging::error($e->getMessage());
|
|
} catch (Exception $e) {
|
|
$this->unknownErrorResponse();
|
|
Logging::error($e->getMessage());
|
|
}
|
|
}
|
|
|
|
public function getAction()
|
|
{
|
|
// podcast ID
|
|
$id = $this->getId();
|
|
if (!$id) {
|
|
return;
|
|
}
|
|
|
|
$episodeId = $this->getEpisodeId();
|
|
if (!$episodeId) {
|
|
return;
|
|
}
|
|
|
|
try {
|
|
$this->getResponse()
|
|
->setHttpResponseCode(201)
|
|
->appendBody(json_encode($this->_service->getPodcastEpisodeById($episodeId)));
|
|
|
|
} catch (PodcastNotFoundException $e) {
|
|
$this->podcastNotFoundResponse();
|
|
Logging::error($e->getMessage());
|
|
} catch (PodcastEpisodeNotFoundException $e) {
|
|
$this->podcastEpisodeNotFoundResponse();
|
|
Logging::error($e->getMessage());
|
|
} catch (Exception $e) {
|
|
$this->unknownErrorResponse();
|
|
Logging::error($e->getMessage());
|
|
}
|
|
}
|
|
|
|
public function postAction()
|
|
{
|
|
//If we do get an episode ID on a POST, then that doesn't make any sense
|
|
//since POST is only for creating.
|
|
if ($episodeId = $this->_getParam('episode_id', false)) {
|
|
$resp = $this->getResponse();
|
|
$resp->setHttpResponseCode(400);
|
|
$resp->appendBody("ERROR: Episode ID should not be specified when using POST. POST is only used for "
|
|
. "importing podcast episodes, and an episode ID will be chosen by Airtime");
|
|
return;
|
|
}
|
|
|
|
// Make sure a podcast ID was specified
|
|
$id = $this->getId();
|
|
if (!$id) {
|
|
return;
|
|
}
|
|
|
|
try {
|
|
$requestData = json_decode($this->getRequest()->getRawBody(), true);
|
|
$episode = $this->_service->importEpisode($id, $requestData["episode"]);
|
|
$this->getResponse()
|
|
->setHttpResponseCode(201)
|
|
->appendBody(json_encode($episode));
|
|
|
|
} catch (Exception $e) {
|
|
$this->unknownErrorResponse();
|
|
Logging::error($e->getMessage());
|
|
}
|
|
|
|
}
|
|
|
|
public function deleteAction()
|
|
{
|
|
$id = $this->getId();
|
|
if (!$id) {
|
|
return;
|
|
}
|
|
|
|
$episodeId = $this->getEpisodeId();
|
|
if (!$episodeId) {
|
|
return;
|
|
}
|
|
|
|
try {
|
|
$this->_service->deletePodcastEpisodeById($episodeId);
|
|
$this->getResponse()
|
|
->setHttpResponseCode(204);
|
|
} catch (PodcastEpisodeNotFoundException $e) {
|
|
$this->podcastEpisodeNotFoundResponse();
|
|
Logging::error($e->getMessage());
|
|
} catch (Exception $e) {
|
|
$this->unknownErrorResponse();
|
|
Logging::error($e->getMessage());
|
|
}
|
|
}
|
|
|
|
public function putAction()
|
|
{
|
|
|
|
}
|
|
|
|
private function getId()
|
|
{
|
|
if (!$id = $this->_getParam('id', false)) {
|
|
$resp = $this->getResponse();
|
|
$resp->setHttpResponseCode(400);
|
|
$resp->appendBody("ERROR: No podcast ID specified.");
|
|
return false;
|
|
}
|
|
return $id;
|
|
}
|
|
|
|
private function getEpisodeId()
|
|
{
|
|
if (!$episodeId = $this->_getParam('episode_id', false)) {
|
|
$resp = $this->getResponse();
|
|
$resp->setHttpResponseCode(400);
|
|
$resp->appendBody("ERROR: No podcast episode ID specified.");
|
|
return false;
|
|
}
|
|
return $episodeId;
|
|
}
|
|
|
|
private function unknownErrorResponse()
|
|
{
|
|
$resp = $this->getResponse();
|
|
$resp->setHttpResponseCode(400);
|
|
$resp->appendBody("An unknown error occurred.");
|
|
}
|
|
|
|
private function podcastNotFoundResponse()
|
|
{
|
|
$resp = $this->getResponse();
|
|
$resp->setHttpResponseCode(404);
|
|
$resp->appendBody("ERROR: Podcast not found.");
|
|
}
|
|
|
|
private function podcastEpisodeNotFoundResponse()
|
|
{
|
|
$resp = $this->getResponse();
|
|
$resp->setHttpResponseCode(404);
|
|
$resp->appendBody("ERROR: Podcast episode not found.");
|
|
}
|
|
|
|
}
|