sintonia/airtime_mvc/application
Lucas Bickel d6a5cbd02e Remove assert() from rest module bootstrap
Problem: assert() is Language construct in php 7 and not a function anymore. It also seems to behave silghtly differently with regards to what kind of side effects assertions are allowed to have. This leads to all of the rest endpoints being broken in php 7 since the assertion silently fails and the routes never really get added to the front controllers router.

Solution: Don't wrap the addRouter call in assert(). The way assert was being uses was rather unusual for php code this age. It was also mostly checking zf1 rather than guarding against errors in LibreTime itself.

The php manual clearly states "As a rule of thumb your code should always be able to work correctly if assertion checking is not activated." giving even more reason to ot wrap critical paths in assertions.

There are some other instances of `assert()` being used in non test code, those don't seem to have any negative effects on php7.
2017-06-07 17:33:23 +02:00
..
auth/adapters FreeIPA Auth Adaptor for LibreTime 2017-03-31 14:16:31 +02:00
cloud_storage Problem: Billing is always on 2017-03-03 15:34:54 +01:00
common Merge pull request #136 from radiorabe/feature/freeipa-auth 2017-04-03 11:50:23 -04:00
configs Only grab ldap config from ini if it exists 2017-04-03 13:46:28 +02:00
controllers Re-assign files to first non deleted admin user 2017-05-22 00:20:02 +02:00
forms added UI to toggle autoplaylist repeat option 2017-03-31 00:00:19 -04:00
layouts/scripts Run more unstranslated Strings through _() 2017-03-24 13:32:15 +01:00
logging Vendorize ZF1, fix PHPUnit and configure travis 2017-02-27 17:59:01 +01:00
models Re-assign files to first non deleted admin user 2017-05-22 00:20:02 +02:00
modules/rest Remove assert() from rest module bootstrap 2017-06-07 17:33:23 +02:00
services added UI to toggle autoplaylist repeat option 2017-03-31 00:00:19 -04:00
upgrade keep db changes in alpha.1 2017-03-31 11:17:26 -04:00
validate Reverted commit mistakenly changing file modifiers to 755 2015-01-14 20:45:03 -05:00
views Uses the minimized angular from public dir instead of cdn 2017-04-18 08:43:44 +02:00
Bootstrap.php Vendorize ZF1, fix PHPUnit and configure travis 2017-02-27 17:59:01 +01:00
airtime-boot.php Vendorize ZF1, fix PHPUnit and configure travis 2017-02-27 17:59:01 +01:00