Commit Graph

12 Commits

Author SHA1 Message Date
paul 488dad1fd9 Cleaned up BasicStor::bsPutFile()/StoredFile::Insert() by making a better set of more extensible parameters. This allowed me to pass in the MD5 and MIME type values, which means those values do not have to be re-calculated when this function is called. This means adding files will be faster now (each calculation of an MD5 value is .25 of a second on my machine). Added a cache to the Metadata class (this class needs serious cleaning up), so that you only have to do one database call and the rest of the time you just use the cache. The number of calls to getMetadataValue() should speedups due to this. Merged the LsPlaylist class into the Playlist class. Importing through the import script and web interface now reads the COMMENT tag and the COMPOSER tag (bug #2108). Moved from using (ls:genre) to (dc:type) for the metadata label for genre and added to the upgrade script to take this into account. Fixed bug in StoredFile::Recall() so that Playlists work again, added an MD5 parameter for this function so that all the Recall functions work in the same way, changed the return value to NULL if the Recall function does not find the record. Made a lot of code more readable and easier to debug. Added StoredFile::getGunid(). 2007-01-21 03:31:19 +00:00
paul 997814e78a Added md5 checksum to FILES table in the database. The XML-RPC function call storeAudioClipOpen now returns error code 888 if the file uploaded is a duplicate of an existing file. Started an upgrade script, but still needs a little bit of work. Removed unused className argument to StoredFile::recall functions. Fixed xr_cli_test.php to use Console_GetOpt PEAR class and fixed code formatting. Fixed code documentation. Fixed some function names to conform to coding standards. 2007-01-09 21:11:45 +00:00
paul 425212bfb8 Possible fix for #2100 - scheduler user is not created. There is now a more verbose output when this step is taken, and also there were previous steps, that if they failed, would prevent this step from happening; so this has been fixed as well. Converted more functions to static functions because thats what they were in the first place...they were just pretending to be member functions. 2006-12-20 02:46:29 +00:00
paul 4733682a62 Refactored Alib to reveal its true nature: a bunch of static functions inside of classes. This makes it much easier to understand what is going on, and removes 4 layers of class heirarchies (now only 4 left). There are now two important global variables: CC_DBC, the database connection, and CC_CONFIG, the config variables. These used to be passed around to all classes, but since they are always the same they should be global. Refactored the StorageServer install scripts to live outside of the classes. They now live in the storageServer install scripts. A lot of functions in the StorageServer have become static as well, but there are definitely more that I didnt get to. Lots of code cleanup as well. This is a big update. 2006-12-16 06:36:22 +00:00
paul b4cecf725d Added public/private/static modifiers to functions. Added function getAllMetadata(). Commented out function updateRecord() which doesnt seem to be used. 2006-11-23 07:05:15 +00:00
paul 001e50bf08 Fix for bug #2003 - CREATE NEW PLAYLIST broken 2006-11-21 18:20:46 +00:00
paul 716b1d3a8c Renamed the function getMetadataValue() to getMetadataValueWithAttrs() - this function actually isnt used anywhere. Created a new getMetadataValue() which just returns the value you are looking for without any extra stuff. 2006-11-21 15:55:39 +00:00
tomash 1b89448983 minor fixes + minor code reformatting 2006-11-16 00:26:50 +00:00
paul bb00be70bb Started to convert code to PHP5 using public/private/protected/static and __construct() method, got rid of =& when constructing objects. Improved documentation in many places. Commented out functions that are no longer in use. Got rid of double-copy operations when checking for errors (e.g. $foo = $r = myMethod()). Tweaked code here and there to fit coding conventions. 2006-11-14 19:09:20 +00:00
tomash 20d6342370 #1903 fixed handling html special characters 2006-10-31 16:20:24 +00:00
paul 55fe551a4a Make sure not to double-escape strings used in SQL. Fixed some formatting to comply with style guidelines. 2006-10-25 20:38:46 +00:00
paul fe31d2dfab Renaming top-level livesupport directory (/trunk/livesupport) to campcaster (trunk/campcaster). 2006-10-19 14:55:07 +00:00